821311 - PBM - Search suggestion text illegible

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/13) - Screenshot

Not sure if another theming bug already will cover this or not; see screenshot.

--
Nightly (12/13)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Sriram - Is this a dupe of the Persona text bug, or is it different?

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Changed the TextView to GeckoTextView and set the private mode when inflated.

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 692053 [details] [diff] [review]
Patch

Review of attachment 692053 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/awesomebar/AllPagesTab.java
@@ +602,5 @@
> +        GeckoTextView promptText = (GeckoTextView) mSuggestionsOptInPrompt.findViewById(R.id.suggestions_prompt_title);
> +        promptText.setText(getResources().getString(R.string.suggestions_prompt, mSearchEngines.get(0).name));
> +
> +        Tab tab = Tabs.getInstance().getSelectedTab();
> +        if (tab != null && tab.isPrivate())

I hate these superfluous null checks...we should maybe try a Try push without them since Talos no longer does session restores (which I believe is why you needed to add these checks to begin with).

Comment 4

[Sriram Ramasubramanian [:sriram]]

https://tbpl.mozilla.org/?tree=Try&rev=ae589618e70a

Comment 5

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e1a57065f541

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/e1a57065f541

Comment 7

[Ioana Chiorean]

Firefox 20.0a1 (2012-11-19)
Device: Galaxy Nexus
OS: Android 4.1.1 

This is not reproducible on latest Nightly. Marking bug as Verified Fixed.