821358 - Port the trace-malloc Windows TLS macros to DMD

Status: RESOLVED FIXED

(Core :: DMD, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

I'm not sure if the patch here is this simple... Nick?

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 691872 [details] [diff] [review]
Patch (v1)

Review of attachment 691872 [details] [diff] [review]:
-----------------------------------------------------------------

As far as I know this is all that's needed.  But I'm a total neophyte when it comes to Windows development

Does this patch allow DMD.cpp to compile?  If it does, you might be in a position to actually run DMD on Windows.  Try following the instructions at https://wiki.mozilla.org/Performance/MemShrink/DMD for Linux, but instead of LD_PRELOAD set MOZ_REPLACE_MALLOC_LIB, and point it at whatever the name of the libdmd library is...

Comment 2

[(no longer active)]

This does not yet let me build this on Windows, but the rest should be fairly simple.  I'm not sure when I'll have enough cycles to try things out but I'll update the main bug once I do.  (And thanks for the link to the docs!)

Comment 3

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9585e38ed39d

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9585e38ed39d

Comment 5

[Justin Lebar (not reading bugmail)]

Comment on attachment 691872 [details] [diff] [review]
Patch (v1)

[Triage Comment]
npotb

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1009e22289f2
https://hg.mozilla.org/releases/mozilla-b2g18/rev/66c65621adbd