821392 - dom/plugins/test/testplugin/nptest_platform.h:59:13: warning: ‘bool pluginSupportsAsyncDXGIDrawing()’ defined but not used [-Wunused-function]

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Daniel Holbert [:dholbert]]

Build warning:
{
dom/plugins/test/testplugin/nptest_platform.h:59:13: warning: ‘bool pluginSupportsAsyncDXGIDrawing()’ defined but not used [-Wunused-function]
}

This method is declared as "static" in a header, which triggers a warning for any file that includes the header without using the method.

I think it wants to be inline, instead of static.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

This fixes it by making the method inline instead of static.  It also marks the directory as warning-free (which it is, on my linux machine).

Try run (to be sure it's also warning-free on mac, the other platform where we enforce that flag):
  https://tbpl.mozilla.org/?tree=Try&rev=8a37c30006af

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> This method is declared as "static" in a header, which triggers a warning
> for any file that includes the header without using the method.

(In particular, it triggers a warning when I'm compiling nptest_gtk2.cpp, which includes the header without using the method.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0ad5a4247d71

Comment 4

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Try run (to be sure it's also warning-free on mac, the other platform where
> we enforce that flag):
>   https://tbpl.mozilla.org/?tree=Try&rev=8a37c30006af

d'oh -- I forgot we also enforce it on Android, too, so this caused android red (due to at least one remaining warning there).

Backed out the warning-free labeling:
 https://hg.mozilla.org/integration/mozilla-inbound/rev/7b689ddc455c
...and I'll file a followup for the android warning.

Comment 5

[Daniel Holbert [:dholbert]]

Looks like this was merged to m-c as:
  https://hg.mozilla.org/mozilla-central/rev/0ad5a4247d71

(and the partial-backout (just for the warning-free labeling) was merged as:
  https://hg.mozilla.org/mozilla-central/rev/7b689ddc455c
)

The sheriff-merge-bug-resolving tool (or the merge sheriff) probably left this bug open due to confusion over whether the backout actually meant this was un-fixed.  To clarify that: the actual code-change stayed in, so this is FIXED.  Resolving as such.