Fix build warnings in content/media/dash

RESOLVED FIXED in mozilla20

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Catalin Iordache, Assigned: Catalin Iordache)

Tracking

(Blocks: 1 bug)

unspecified
mozilla20
All
Linux
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 691894 [details] [diff] [review]
p2v1.patch

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:17.0) Gecko/20100101 Firefox/17.0
Build ID: 20121129151900

Steps to reproduce:

Fix warnings in content/media/dash/DASHDecoder.cpp and content/media/dash/DASHRepDecoder.cpp
(Assignee)

Comment 1

5 years ago
I'm a beginner developer. This is actually my second patch for Mozilla codebase, but I have to say that the first one wasn't relevant( bug 821269).

I hope this one is more relevant.
(Assignee)

Updated

5 years ago
Hardware: x86 → All
(Assignee)

Updated

5 years ago
Attachment #691894 - Flags: review?
Component: Disability Access APIs → DOM
(Assignee)

Updated

5 years ago
Attachment #691894 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #691894 - Flags: review?

Updated

5 years ago
Attachment #691894 - Flags: review? → review?(bugs)

Updated

5 years ago
Attachment #691894 - Flags: review?(bugs) → review?(cpearce)
Comment on attachment 691894 [details] [diff] [review]
p2v1.patch

Review of attachment 691894 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/dash/DASHRepDecoder.cpp
@@ +270,5 @@
>    // i.e. inactive rep decoders should only load metadata.
>    bool canDownloadData = mMainDecoder->IsDecoderAllowedToDownloadData(this);
>    if (canDownloadData) {
> +    for (uint32_t i = 0; i < mByteRanges.Length(); i++) {
> +      NS_ENSURE_FALSE(mByteRanges[i].IsNull(), NS_ERROR_NOT_INITIALIZED);    

You added some trailing whitespace here; please remove it.
(Assignee)

Comment 3

5 years ago
Created attachment 692590 [details] [diff] [review]
whitespaces removed
Attachment #691894 - Attachment is obsolete: true
Attachment #691894 - Flags: review?(cpearce)
(Assignee)

Updated

5 years ago
Attachment #692590 - Flags: review?

Updated

5 years ago
Blocks: 187528

Updated

5 years ago
Attachment #692590 - Flags: review? → review?(cpearce)
Comment on attachment 692590 [details] [diff] [review]
whitespaces removed

Review of attachment 692590 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/dash/DASHDecoder.cpp
@@ +697,5 @@
>  
>        // Do Stream Switching here before loading next bytes.
>        // Audio stream switching not supported.
>        if (aRepDecoder == VideoRepDecoder() &&
> +          (uint32_t)mVideoSubsegmentIdx < VideoRepDecoder()->GetNumDataByteRanges()) {

Make this:
uint32_t(mVideoSubsegmentIdx)

@@ +938,5 @@
>    NS_ENSURE_TRUE(toDecoderIdx < mVideoRepDecoders.Length(),
>                   NS_ERROR_ILLEGAL_VALUE);
>  
>    // Notify reader and sub decoders and do the switch.
> +  if (toDecoderIdx != (uint32_t)mVideoRepDecoderIdx) {

Make this:
uint32_t(mVideoRepDecoderIdx)
Attachment #692590 - Flags: review?(cpearce) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 692958 [details] [diff] [review]
added for checkin
Attachment #692958 - Flags: checkin?
Blocks: 819664
(Assignee)

Updated

5 years ago
Attachment #692958 - Flags: checkin?
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Attachment #692590 - Attachment is obsolete: true
Attachment #692958 - Attachment is patch: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba26ddd4739b
Assignee: nobody → catalinn.iordache
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba26ddd4739b
Status: UNCONFIRMED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.