821401 - mozilla-b2g18 should build desktop b2g builds on checkin

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[John Ford [:jhford] CET/CEST Berlin Time]

This branch is limited in scope to B2G only changes.  Given the relatively high chance of someone landing on this branch and wanting to test their changes with a desktop build coupled with the relatively low volume of checkins, we should consider building the b2g desktop builds on this branch on each change.

Comment 1

[John O'Duinn [:joduinn] (please use "needinfo?" flag)]

found in triage, moving to correct component.

Comment 2

[Chris AtLee [:catlee]]

should we be building firefox at all on this branch?

or, alternatively, should we enable the per-product building logic on this branch? (e.g. only build b2g if only b2g/ changes)

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Chris AtLee [:catlee] from comment #2)
> should we be building firefox at all on this branch?
> 
> or, alternatively, should we enable the per-product building logic on this
> branch? (e.g. only build b2g if only b2g/ changes)

I asked Alex about this last week, and he said that we should.

Comment 4

[Aki Sasaki (not active)]

Clarification: do you mean desktop Firefox, or desktop b2g ?

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was referring to Desktop B2G

Comment 6

[Aki Sasaki (not active)]

(In reply to Chris AtLee [:catlee] from comment #2)
> should we be building firefox at all on this branch?
> 
> or, alternatively, should we enable the per-product building logic on this
> branch? (e.g. only build b2g if only b2g/ changes)

a) since b2g18 is b2g-oriented, if we did this I'd say we should build b2g on all changes, and don't build firefox if the change is only in b2g/.

b) since this bug is desktop b2g specific, this is a question outside the scope of this bug :)

Comment 7

[Aki Sasaki (not active)]

Attachment: (custom) needed to pass checkconfig

Comment 8

[Aki Sasaki (not active)]

Attachment: (configs) b2g desktop dep builds on b2g18

Comment 9

[Aki Sasaki (not active)]

Comment on attachment 692038 [details] [diff] [review]
(custom) needed to pass checkconfig

http://hg.mozilla.org/build/buildbotcustom/rev/122bc65a26bd

Comment 10

[Aki Sasaki (not active)]

Comment on attachment 692039 [details] [diff] [review]
(configs) b2g desktop dep builds on b2g18

http://hg.mozilla.org/build/buildbot-configs/rev/fdd3eee6392f

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

In production.

Comment 12

[Aki Sasaki (not active)]

These are getting a --config-file None for the multilocale portion.
Hidden, need to fix.

Comment 13

[Aki Sasaki (not active)]

Attachment: fix dep b2g desktop builds

This adds the multilocale bits to the dep kwargs, but only for b2g.
I should also investigate a solution around this that keys off of "enable_multilocale_dep" or something instead of looking at the product.

I'd like to test a dep+nightly b2g desktop build to verify both are multilocale, and a dep+nightly android build to verify only android nightlies are multilocale.

Comment 15

[Aki Sasaki (not active)]

Comment on attachment 692130 [details] [diff] [review]
fix dep b2g desktop builds

Dep+nightly b2g linux desktop : multilocale with a proper --config-file
Nightly android: multilocale
Dep android: non-multilocale

Comment 16

[[e-mail] (:bhearsum)]

Comment on attachment 692130 [details] [diff] [review]
fix dep b2g desktop builds

Review of attachment 692130 [details] [diff] [review]:
-----------------------------------------------------------------

Heh, looks very similar to the original patch that I thought wouldn't be necessary. Hooray for horrible hacks!

Comment 17

[Aki Sasaki (not active)]

Comment on attachment 692130 [details] [diff] [review]
fix dep b2g desktop builds

http://hg.mozilla.org/build/buildbotcustom/rev/ee3f1f6c0c4f

Comment 18

[Kim Moir [:kmoir] ET]

In production

Comment 19

[Aki Sasaki (not active)]

Hm, the 'check' tests seem to be broken.

:bhearsum, :jhford, should we be running 'make check' for desktop b2g builds?  (hg blame tells me you two set those flags.)

If not, I can turn those off and get these builds green (currently orange on mozilla-b2g18).

If so, we need to otherwise get these builds green to unhide them.
I clobbered these builds; maybe that'll help.

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to Aki Sasaki [:aki] from comment #19)
> Hm, the 'check' tests seem to be broken.
> 
> :bhearsum, :jhford, should we be running 'make check' for desktop b2g
> builds?  (hg blame tells me you two set those flags.)
> 
> If not, I can turn those off and get these builds green (currently orange on
> mozilla-b2g18).
> 
> If so, we need to otherwise get these builds green to unhide them.
> I clobbered these builds; maybe that'll help.

It would be great to have the check tests run green, but I think having the builds visible is going to catch more errors than if they are hidden.

Comment 21

[Aki Sasaki (not active)]

Attachment: disable b2g18 b2g desktop check tests

Going to stage this.

Comment 22

[Aki Sasaki (not active)]

Comment on attachment 693554 [details] [diff] [review]
disable b2g18 b2g desktop check tests

Sorry for all the reviews.
Kicked off a b2g linux b2g18 build in staging and verified there was no check step, and it ran green.

Comment 23

[Aki Sasaki (not active)]

Comment on attachment 693554 [details] [diff] [review]
disable b2g18 b2g desktop check tests

http://hg.mozilla.org/build/buildbot-configs/rev/0c704b8095ce

Comment 24

[Aki Sasaki (not active)]

These appear to be green now.