821410 - Add support for bitbucket for the 'See Also' field

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Michał Górny]

Please add support for adding bitbucket project issues in the 'See Also' field.

The bitbucket issue trackers use URLs like:

    https://bitbucket.org/<user>/<project>/issue/<n>

where <user> & <project> would be \S+?, and <n> would be \d+.

Comment 1

[Koosha KM]

Attachment: patch - v1

Comment 2

[Koosha KM]

Attachment: patch - v1

ah, forgot to ignore the case.

Comment 3

[Frédéric Buclin]

Comment on attachment 692004 [details] [diff] [review]
patch - v1

Move this into the MoreBugUrl extension.

Comment 4

[Koosha KM]

Attachment: patch - v2

OK then, moved the code to the extension.

Comment 5

[Frédéric Buclin]

Comment on attachment 692238 [details] [diff] [review]
patch - v2

>=== added file 'extensions/MoreBugUrl/lib/BitBucket.pm'
>+    return ($uri->authority =~ /^bitbucket.org$/i

It's a regexp, so you must escape dots as \., see bug 825758.


>+            && $uri->path =~ m|\S+/\S+/issue/\d+|i) ? 1 : 0;

\S accepts any non-whitespace character, including /, so this regexp doesn't do its job correctly. You must use [^/] instead of \S.


>+sub _check_value {

It must sanitize URLs. An issue on bitbucket.org can have a URL of the form

  https://bitbucket.org/ehsan/bugzilla-tweaks/issue/13/add-option-to-hide-possible-duplicates-ui

but Bugzilla should only store

  https://bitbucket.org/ehsan/bugzilla-tweaks/issue/13

which will point to the same issue. See how this is done in Bugzilla/BugUrl/Launchpad.pm.

Comment 6

[Koosha KM]

Attachment: patch v3

Comment 7

[Frédéric Buclin]

Comment on attachment 697475 [details] [diff] [review]
patch v3

>=== added file 'extensions/MoreBugUrl/lib/BitBucket.pm'

>+package Bugzilla::Extension::MoreBugUrl::BitBucket;
>+use strict;
>+use base qw(Bugzilla::BugUrl);

Missing |use 5.10.1|. Also, s/use base/use parent/.


Otherwise looks good. r=LpSolit

Comment 8

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified extensions/MoreBugUrl/Extension.pm
added extensions/MoreBugUrl/lib/BitBucket.pm
modified extensions/MoreBugUrl/template/en/default/hook/global/user-error-bug_url_invalid_tracker.html.tmpl
Committed revision 8569.