821424 - Remote cpp unit tests: make target for running all tests in a directory

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Geoff Brown [:gbrown]]

Similar to http://mxr.mozilla.org/mozilla-central/source/config/rules.mk#108

Comment 1

[Geoff Brown [:gbrown]]

Attachment: allow make -C <dir> cppunittests-remote

This seems to work for me. I tested with:

make -C xpcom/tests cppunittests-remote
make -C netwerk/test cppunittests-remote

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 693536 [details] [diff] [review]
allow make -C <dir> cppunittests-remote

Review of attachment 693536 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with a few changes.

::: config/rules.mk
@@ +107,5 @@
>  
>  check::
>  	@$(PYTHON) $(topsrcdir)/testing/runcppunittests.py --xre-path=$(DIST)/bin --symbols-path=$(DIST)/crashreporter-symbols $(subst .cpp,$(BIN_SUFFIX),$(CPP_UNIT_TESTS))
>  
> +REMOTE_CPPUNITTESTS = \

If we're not reusing this anywhere there's not much point in defining it in a variable.

@@ +108,5 @@
>  check::
>  	@$(PYTHON) $(topsrcdir)/testing/runcppunittests.py --xre-path=$(DIST)/bin --symbols-path=$(DIST)/crashreporter-symbols $(subst .cpp,$(BIN_SUFFIX),$(CPP_UNIT_TESTS))
>  
> +REMOTE_CPPUNITTESTS = \
> +	rm -f ./$@.log && \

You don't need the logging bits here.

@@ +111,5 @@
> +REMOTE_CPPUNITTESTS = \
> +	rm -f ./$@.log && \
> +	$(PYTHON) -u $(topsrcdir)/config/pythonpath.py \
> +	  -I$(topsrcdir)/build \
> +	  -I$(topsrcdir)/testing/mozbase/mozdevice/mozdevice \

You shouldn't need to use pythonpath here, these things should all be in the Python virtualenv nowadays. Drop pythonpath.py and the -I bits.

@@ +114,5 @@
> +	  -I$(topsrcdir)/build \
> +	  -I$(topsrcdir)/testing/mozbase/mozdevice/mozdevice \
> +	  $(topsrcdir)/testing/remotecppunittests.py \
> +	  --xre-path=$(DEPTH)/dist/bin \
> +	  --localLib=$(DEPTH)/dist/fennec \

This probably wants to be $(MOZ_APP_NAME) instead of hardcoding fennec.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: allow make -C <dir> cppunittests-remote

Updated for review comments. r=ted 

Thanks for the great feedback -- this is much tidier!

Comment 4

[Geoff Brown [:gbrown]]

Attachment: allow make -C <dir> cppunittests-remote

D'oh! Attached the wrong patch.

Comment 5

[Geoff Brown [:gbrown]]

Attachment: allow make -C <dir> cppunittests-remote

Re-based for new patch on bug 811411.

Comment 6

[Geoff Brown [:gbrown]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/354fcf80053a

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/354fcf80053a