Closed Bug 821438 Opened 11 years ago Closed 11 years ago

Update to spec changes for [Unforgeable]

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file, 1 obsolete file)

See thread at http://lists.w3.org/Archives/Public/public-script-coord/2012OctDec/0262.html

Summary is that the requirement that interfaces with [Unforgeable] can't be inherited from is gone.  The new requirement is:

  If interface A inherits from interface B, and either B or one of its
  consequential interfaces has a [Unforgeable]-annotated attribute,
  then A and all its consequential interfaces MUST NOT have an
  attribute with the same identifier.
Attachment #691985 - Attachment is obsolete: true
Attachment #691985 - Flags: review?(peterv)
Comment on attachment 692175 [details] [diff] [review]
Now allowing static stuff and constants, since those don't really shadow

Review of attachment 692175 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +587,5 @@
> +            # Make sure we don't shadow any of the [Unforgeable] attributes on
> +            # our ancestor interfaces.  We don't have to worry about
> +            # consequential interfaces here, because those have already been
> +            # imported into the relevant .members lists.  And we don't have to
> +            # worry about anything other than our parent, because it's already

s/it's/it has/?
Attachment #692175 - Flags: review?(peterv) → review+
Sure.  "it's" can actually mean either "it is" or "it has", but spelling it out is better if confusion ensues.  ;)
https://hg.mozilla.org/integration/mozilla-inbound/rev/91a7872bb725
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/91a7872bb725
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: