821438 - Update to spec changes for [Unforgeable]

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

See thread at http://lists.w3.org/Archives/Public/public-script-coord/2012OctDec/0262.html

Summary is that the requirement that interfaces with [Unforgeable] can't be inherited from is gone.  The new requirement is:

  If interface A inherits from interface B, and either B or one of its
  consequential interfaces has a [Unforgeable]-annotated attribute,
  then A and all its consequential interfaces MUST NOT have an
  attribute with the same identifier.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Allow inheritance from interfaces with Unforgeable attributes.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Now allowing static stuff and constants, since those don't really shadow

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 692175 [details] [diff] [review]
Now allowing static stuff and constants, since those don't really shadow

Review of attachment 692175 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/bindings/parser/WebIDL.py
@@ +587,5 @@
> +            # Make sure we don't shadow any of the [Unforgeable] attributes on
> +            # our ancestor interfaces.  We don't have to worry about
> +            # consequential interfaces here, because those have already been
> +            # imported into the relevant .members lists.  And we don't have to
> +            # worry about anything other than our parent, because it's already

s/it's/it has/?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Sure.  "it's" can actually mean either "it is" or "it has", but spelling it out is better if confusion ensues.  ;)

Comment 5

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/91a7872bb725

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/91a7872bb725