821439 - Signaling code is leaking instances of RemoteSourceStreamInfo

Status: RESOLVED DUPLICATE of bug 820102

(Core :: WebRTC: Signaling, defect)

Description

[Ethan Hugg [:ehugg]]

Either one too many addrefs or one too few releases of RemoteSourceStreamInfo are causing them to stay around.

Comment 1

[Ethan Hugg [:ehugg]]

Attachment: Stop leaking RemoteSourceStreamInfo

Comment 2

[Ethan Hugg [:ehugg]]

Comment on attachment 691996 [details] [diff] [review]
Stop leaking RemoteSourceStreamInfo


Is this the way you considered removing the AddRefs?

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

r- but trivially resolvable

media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp

> nsresult
> PeerConnectionImpl::MakeRemoteSource(nsDOMMediaStream* aStream, > nsRefPtr<RemoteSourceStreamInfo>* aInfo)
	
I'd prefer a signature like:
already_AddRefed<RemoteSourceStreamInfo>
PeerConnectionImpl::MakeRemoteSource(nsDOMMediaStream* aStream)
{
  MOZ_ASSERT(aStream);
  nsRefPtr<RemoteSourceStreamInfo> info = new RemoteSourceStreamInfo(aStream);
  return info.forget();
}
Avoids extra refs, avoids the useless nsresult that's ignored, avoids passing a pointer to an nsRefPtr, etc.
Alternatively, use nsRefPtr<>& instead of * - this is the common usage for that sort of thing

 
nsresult
PeerConnectionImpl::CreateRemoteSourceStreamInfo(uint32_t aHint, nsRefPtr<RemoteSourceStreamInfo>* aInfo)
	
And somewhat similarly:
PeerConnectionImpl::CreateRemoteSourceStreamInfo(uint32_t aHint, nsRefPtr<RemoteSourceStreamInfo>& aInfo)

Comment 4

[Ethan Hugg [:ehugg]]

This will will be fixed as part of the patch to Bug 820102.  Setting this as a dupe.