821449 - {inc} After incremental layout of stretched, nested flex container, inner flex container is no longer stretched

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: testcase 1

STR: Load testcase; hover the green box; un-hover.

EXPECTED RESULTS: black border appears when hovered. No red visible.
ACTUAL RESULTS: black border appears _and the green box shrinkwraps its text's height_ when hovered, and stays that height after un-hovered.

Testcase reduced from bug 820111.

See also related bug 821426 (though that bug's patch doesn't fix this bug's testcase).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

This fix marks our children as CONTAINS_RELATIVE_HEIGHT if they're in a horizontal flexbox & they're stretched vertically.

Testcase included (as a modified copy of the testcase from bug 821426).  I verified that it fails before this patch is applied, and passes afterwards.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 692213 [details] [diff] [review]
fix v1

r=dbaron

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ecf7bc3e34b3

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/mozilla-central/rev/ecf7bc3e34b3