Closed
Bug 821495
Opened 13 years ago
Closed 13 years ago
Compile warning: "AudioSampleFormat.h(146) : warning C4244: 'initializing' : conversion from 'float' to 'int32_t', possible loss of data"
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
|
700 bytes,
patch
|
kinetik
:
review+
|
Details | Diff | Splinter Review |
I get a compile warning on Win7 when building content/media:
AudioSampleFormat.h(146) : warning C4244: 'initializing' : conversion from 'float' to 'int32_t', possible loss of data
This is spamming my console with warnings that aren't useful.
|
Assignee | |
Updated•13 years ago
|
Attachment #692027 -
Attachment is patch: true
Attachment #692027 -
Flags: review?(kinetik)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 692027 [details] [diff] [review]
Patch
+ int32_t volume = int32_t(int32_t(1 << 16) * aScale);
Make it:
+ int32_t volume = int32_t((1 << 16) * aScale);
Attachment #692027 -
Flags: review?(kinetik) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Landed with requested change:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb6ef9590c39
Thanks!
|
||
Comment 3•13 years ago
|
||
Assignee: nobody → cpearce
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•