821507 - WARNING resource://gre/modules/XPIProvider.jsm:890 test for equality (==) mistyped as assignment

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Daniel Holbert [:dholbert]]

Noticed this (as the first few lines of output) when starting up a debug build today:
{
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm:890
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm:1315
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/XPIProvider.jsm:2174
                     test for equality (==) mistyped as assignment (=)?
JS Component Loader: WARNING resource://gre/modules/PluginProvider.jsm:239
                     test for equality (==) mistyped as assignment (=)?
}

Looks like these are all for loops that intentionally do an assignment in the loop-condition, e.g.:
> 890     while (entry = entries.nextFile)
> 891       size += getFileSize(entry);
https://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/XPIProvider.jsm#890

In C++, you can silence warnings like this by adding an extra layer of parens around the assignment.  I'm guessing that'll work in JS, too...

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

(I verified locally that this fixes the warnings.)

Comment 3

[Dave Townsend [:mossop]]

Comment on attachment 692047 [details] [diff] [review]
fix v1

Seems a little silly but sure

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4519670ac62d

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4519670ac62d