82156 - Lock icon is not accurate

Status: VERIFIED WORKSFORME

(Core Graveyard :: Security: UI, defect, P1)

Description

[John Unruh]

WinNT Netscape 6 5/22 build. The above is an in-house URL.
1.) When using the tests at the top left of the page, I find that lock is 
staying broken on secure sites, while page info shows that the site is secure.

Comment 1

[Bob Lord]

Target -> 2.0
Priority -> P1

Comment 2

[David P. Drinan]

This bug depends on 85211

Comment 3

[David P. Drinan]

Attachment: Patch. Javi, please review.

Comment 4

[Javier Delgadillo]

+    PRUnichar* tooltip = nsnull;
+    if (info) {
+      nsCOMPtr<nsITransportSecurityInfo> secInfo(do_QueryInterface(info));
+      if (secInfo &&
+          NS_SUCCEEDED(secInfo->GetShortSecurityDescription(&tooltip)) &&


tooltip should be of type nsXPIDLString.
then change to secInfo->GetShortDescription(getter_Copies(tooltip));
and get rid of line PR_Free(tooltip);

Fix that, and r=jav

Comment 5

[David P. Drinan]

Attachment: Updated patch with Javi's review comments. Blizzard, please sr.

Comment 6

[Christopher Blizzard (:blizzard)]

sr=blizzard

Comment 7

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 8

[Stephane Saux]

PDT for PSM

Comment 9

[Stephane Saux]

PDT+ as per Steve Elmeer 6/20/2001

Comment 10

[John Unruh]

Marking worksforme. My tests don't break correct lock icon behavior.

Comment 11

[David P. Drinan]

Actually, I forgot to update the bug when I checked in, so this should be marked 
fixed. However, I still suspect that there are more bugs lurking around the 
lock icon, so please keep trying to find edge cases that trip it up.

Comment 12

[John Unruh]

Reopen to mark fixed.

Comment 13

[John Unruh]

Fixed

Comment 14

[John Unruh]

Reopening. At https://www.ecount.com/ right click on a link and open in a new 
browser window. The lock icon will appear broken.

Comment 15

[selmer (gone)]

Please update the status whiteboard with your new eta since this was reopened again.

Comment 16

[Bob Lord]

Confirmed, though this problem also shows up on other HTTPS sites as well.  Note
that hitting Reload in the new window causes the lock to set itself correctly.

Comment 17

[Stephane Saux]

David is working hard on this one to track the last issues.
Add "reopened" to whiteboard.

Comment 18

[David P. Drinan]

The problem I'm having is that the correct behaviour is happening in my debug 
build which, as you might expect, is making it difficult to isolate the problem.

Comment 19

[David P. Drinan]

This works for me in my trunk build and in the last nights branch build. Marking
WORKSFORME.

Comment 20

[John Unruh]

Verified worksforme.