Closed
Bug 821621
Opened 12 years ago
Closed 12 years ago
Fix some warnings about unused WebRTC functions and variables
Categories
(Core :: WebRTC, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
2.11 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
When building with clang on OSX, I see a number of warnings about unused functions in .cpp files that #include voice_engine_defines.h: media/webrtc/trunk/src/voice_engine/voice_engine_defines.h:493:10: warning: unused function 'Sleep' [-Wunused-function] media/webrtc/trunk/src/voice_engine/voice_engine_defines.h:501:11: warning: unused function 'WebRtcTimeGetTime' [-Wunused-function] media/webrtc/signaling/src/peerconnection/PeerConnectionCtx.cpp:36:8: warning: unused variable 'on' [-Wunused-variable] The Sleep() and WebRtcTimeGetTime() functions are defined in an unnamed namespace. clang still complains if I make the functions inline. To suppress clang's warnings, I had to make the functions static inline.
Attachment #692219 -
Flags: review?(rjesup)
Comment 1•12 years ago
|
||
Comment on attachment 692219 [details] [diff] [review] fix-warnings.patch Review of attachment 692219 [details] [diff] [review]: ----------------------------------------------------------------- I'm fine with the PeerConnectionCtx change The voice_engines_defines: the bar is a bit higher there as it's imported code; we'd want to file an upstream bug (if it isn't already fixed). r+, but please go to webrtc.org and file an 'issue' with a pointer to this bug/patch, and then add it as a comment here and make this bug dependent on the bug webrtc_updates It's very easy to file a bug there. If you really prefer not to, say so here and I'll do it. Thanks for doing the cleanup!
Attachment #692219 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 2•12 years ago
|
||
(In reply to Randell Jesup [:jesup] from comment #1) > The voice_engines_defines: the bar is a bit higher there as it's imported > code; we'd want to file an upstream bug (if it isn't already fixed). r+, > but please go to webrtc.org and file an 'issue' with a pointer to this > bug/patch, and then add it as a comment here and make this bug dependent on > the bug webrtc_updates No problem; I will file a bug upstream with the fix.
Assignee | ||
Comment 3•12 years ago
|
||
I landed the PeerConnectionCtx.cpp fix on m-i: https://hg.mozilla.org/integration/mozilla-inbound/rev/7c43da37e53f I submitted the voice_engines_defines.h fixes upstream to webrtc: https://code.google.com/p/webrtc/issues/detail?id=1228
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7c43da37e53f
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•