821757 - NS_ERROR_MALFORMED_URI in getBookmarkURI while building Sync GUID map

Status: RESOLVED INCOMPLETE

(Toolkit :: Places, defect)

Description

[Richard Newman [:rnewman]]

1355486001656   Sync.Engine.Bookmarks      WARN  Got exception "Component returned failure code: 0x804b000a (NS_ERROR_MALFORMED_URI) [nsINavBookmarksService.getBookmarkURI] Stack trace: _buildGUIDMap()@resource:///modules/services-sync/engines/bookmarks.js:248 < resource:///modules/services-sync/engines/bookmarks.js:359 < _mapDupe()@resource:///modules/services-sync/engines/bookmarks.js:315 < _createRecord()@resource:///modules/services-sync/engines/bookmarks.js:399 < _reconcile()@resource://services-sync/engines.js:1139 < resource://services-sync/engines.js:845 < resource://services-sync/record.js:608 < Channel_onDataAvail()@resource:///modules/services-sync/resource.js:527" building GUID map. Skipping all other incoming items.

http://mozservices.pastebin.mozilla.org/1994804

http://hg.mozilla.org/releases/mozilla-release/file/5d9e4c7823a7/services/sync/modules/engines/bookmarks.js#l248


_buildGUIDMap looks only at the local Places DB. That means that we're getting an error when we retrieve a bookmark that:

  getItemType == TYPE_BOOKMARK
  !getItemAnnotation(id, SMART_BOOKMARKS_ANNO)
  PlacesUtils.bookmarks.getBookmarkURI(id) => throws.

As far as I can tell, that means there's a bookmark in the DB with a malformed URI.

mak, any other insight?

Comment 1

[Marco Bonardo [:mak]]

There's no way a corrupted uri may enter the db, cause all the APIs use nsIURI. Obviously I'm excluding direct editing through the connection or from a third party.

The only thing I may think about here, is that this may be a folder with the wrong item_type... though, if it's so, the weekly maintenance should fix it. Though again I'm not sure how this could happen through the API :(

Comment 2

[Richard Newman [:rnewman]]

Well, this is a conundrum!

Comment 3

[Marco Bonardo [:mak]]

I can only call this incomplete, all of the entering points are protected by nsIURI, that means this comes from "somewhere". since we don't have the original source to verify that I doubt we can do anything to investigate it.

Comment 5

[Richard Newman [:rnewman]]

This just came up in SUMO.

https://support.mozilla.org/en-US/questions/997250

Comment 6

[Richard Newman [:rnewman]]

User reports that around Firefox 27, bookmarks were imported from a Yahoo-branded Firefox. I could certainly imagine that being an input vector for dodgy data.

Comment 7

[Thomas Stache]

I just ran into this today morning when returning to my work PC. Used it yesterday all day, then used my home PC connected to the same FxAccount in the evening, and returned to the work PC.

I made copies of sync-logs, and places.sqlite (~62MB), before resorting to the "Places Maintenance" addon.
In the end I ran "All" maintenance tasks - and sync returned to working state.