821796 - "aData is null" when updating hosted apps

Status: RESOLVED FIXED

(Core Graveyard :: DOM: Apps, defect)

Description

[Julien Wajsberg [:julienw]]

When updating an hosted app, there is an error in the log :

E/GeckoConsole(  108): [JavaScript Error: "aData is null" {file: "resource://gre/modules/Webapps.jsm" line: 1041}]

I believe this comes from http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.jsm#1154

because the 3rd argument in the Observer is always null, as seen in : https://mxr.mozilla.org/mozilla-central/source/uriloader/prefetch/nsOfflineCacheUpdate.cpp#2013

This is very easily fixed in Webapps.jsm by not using the observer argument (renaming it to "unused" or maybe even removing it) and using the aData variable from the outer scope.

I think this bug prevents us from updating hosted apps with appcache, so I believe this is very serious.

Comment 1

[[:fabrice] Fabrice Desré]

Thanks for the investigation. I pushed a trivial fix as part of https://hg.mozilla.org/integration/mozilla-inbound/rev/f75a9f57c14e

Comment 2

[Julien Wajsberg [:julienw]]

I saw you committed also a fix for the GetBasePath case; I didn't open a bug for this one because I couldn't find when it would happen. Do you have an idea ? There might be a bug in Gaia...

Comment 3

[[:fabrice] Fabrice Desré]

GetBasePath failing can happen in two cases:
- web content asking for an invalid app://APP_ID/ url.
- something went really wrong in the backend.

In both cases, we can't do much more than failing as gracefully as possible.

Comment 4

[Julien Wajsberg [:julienw]]

Ok. I've seen it but maybe it was due to other bugs (like Bug 821288).

Let's see if we encounter the log again.

Thanks !