The default bug view has changed. See this FAQ.

signalling code hangs on android because it has no writable tmpdir for domain sockets

RESOLVED FIXED in mozilla20

Status

()

Core
WebRTC: Signaling
P1
normal
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dmose, Assigned: dmose)

Tracking

Trunk
mozilla20
ARM
Android
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
Splitting off from bug 819854; patch in progress.
(Assignee)

Updated

4 years ago
Depends on: 794240
(Assignee)

Updated

4 years ago
Blocks: 819854
Whiteboard: [WebRTC], [blocking-webrtc-]
Priority: -- → P1
(Assignee)

Comment 1

4 years ago
Created attachment 694587 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks

The comments in the patch should explain what's going on; there is a bit of additional context in bug 823741, which is linked to from the patch as well.
Attachment #694587 - Flags: review?(rjesup)
(Assignee)

Comment 2

4 years ago
Try server build in progress: 

https://tbpl.mozilla.org/?tree=Try&rev=2566574e04fa
Comment on attachment 694587 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks

Review of attachment 694587 [details] [diff] [review]:
-----------------------------------------------------------------

trailing spaces...
Attachment #694587 - Flags: review?(rjesup) → review+
(Assignee)

Comment 4

4 years ago
Created attachment 694905 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks, v2

Removed trailing spaces; carrying forward r=jesup.
Attachment #694587 - Attachment is obsolete: true
Attachment #694905 - Flags: review+
(Assignee)

Comment 5

4 years ago
Pushed to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f94e6ce99f7

Setting in-testsuite+, as signalling_unittests cover this, and are in fact what found the problem.
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/3f94e6ce99f7
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20

Updated

4 years ago
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
Comment on attachment 694905 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks, v2

Review of attachment 694905 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/sipstack/sip_platform_task.c
@@ +152,5 @@
> + *
> + * @return            The length of the written output not including the NULL
> + *                    terminator, or -1 if an error occurs.
> + */
> +static PRUint32 sip_get_sock_dir_tmpl(char *out, PRUint32 outlen,

For future reference, we use uint32_t.
(Assignee)

Comment 8

4 years ago
Good catch; thanks.  I'll keep the NSPR types encapsulated in future patches.
You need to log in before you can comment on or make changes to this bug.