Closed
Bug 821812
Opened 12 years ago
Closed 12 years ago
signalling code hangs on android because it has no writable tmpdir for domain sockets
Categories
(Core :: WebRTC: Signaling, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: dmosedale, Assigned: dmosedale)
References
Details
(Whiteboard: [WebRTC], [blocking-webrtc-] [qa-])
Attachments
(1 file, 1 obsolete file)
7.55 KB,
patch
|
dmosedale
:
review+
|
Details | Diff | Splinter Review |
Splitting off from bug 819854; patch in progress.
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-]
Updated•12 years ago
|
Priority: -- → P1
Assignee | ||
Comment 1•12 years ago
|
||
The comments in the patch should explain what's going on; there is a bit of additional context in bug 823741, which is linked to from the patch as well.
Attachment #694587 -
Flags: review?(rjesup)
Assignee | ||
Comment 2•12 years ago
|
||
Try server build in progress: https://tbpl.mozilla.org/?tree=Try&rev=2566574e04fa
Comment 3•12 years ago
|
||
Comment on attachment 694587 [details] [diff] [review] Attempt to use TMPDIR with defined fallbacks for IPC socks Review of attachment 694587 [details] [diff] [review]: ----------------------------------------------------------------- trailing spaces...
Attachment #694587 -
Flags: review?(rjesup) → review+
Assignee | ||
Comment 4•12 years ago
|
||
Removed trailing spaces; carrying forward r=jesup.
Attachment #694587 -
Attachment is obsolete: true
Attachment #694905 -
Flags: review+
Assignee | ||
Comment 5•12 years ago
|
||
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/3f94e6ce99f7 Setting in-testsuite+, as signalling_unittests cover this, and are in fact what found the problem.
Flags: in-testsuite+
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3f94e6ce99f7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Updated•12 years ago
|
Whiteboard: [WebRTC], [blocking-webrtc-] → [WebRTC], [blocking-webrtc-] [qa-]
Comment 7•12 years ago
|
||
Comment on attachment 694905 [details] [diff] [review] Attempt to use TMPDIR with defined fallbacks for IPC socks, v2 Review of attachment 694905 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/webrtc/signaling/src/sipcc/core/sipstack/sip_platform_task.c @@ +152,5 @@ > + * > + * @return The length of the written output not including the NULL > + * terminator, or -1 if an error occurs. > + */ > +static PRUint32 sip_get_sock_dir_tmpl(char *out, PRUint32 outlen, For future reference, we use uint32_t.
Assignee | ||
Comment 8•12 years ago
|
||
Good catch; thanks. I'll keep the NSPR types encapsulated in future patches.
You need to log in
before you can comment on or make changes to this bug.
Description
•