821812 - signalling code hangs on android because it has no writable tmpdir for domain sockets

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Splitting off from bug 819854; patch in progress.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Attempt to use TMPDIR with defined fallbacks for IPC socks

The comments in the patch should explain what's going on; there is a bit of additional context in bug 823741, which is linked to from the patch as well.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Try server build in progress: 

https://tbpl.mozilla.org/?tree=Try&rev=2566574e04fa

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 694587 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks

Review of attachment 694587 [details] [diff] [review]:
-----------------------------------------------------------------

trailing spaces...

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Attempt to use TMPDIR with defined fallbacks for IPC socks, v2

Removed trailing spaces; carrying forward r=jesup.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

Pushed to mozilla-inbound:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f94e6ce99f7

Setting in-testsuite+, as signalling_unittests cover this, and are in fact what found the problem.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/3f94e6ce99f7

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 694905 [details] [diff] [review]
Attempt to use TMPDIR with defined fallbacks for IPC socks, v2

Review of attachment 694905 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/signaling/src/sipcc/core/sipstack/sip_platform_task.c
@@ +152,5 @@
> + *
> + * @return            The length of the written output not including the NULL
> + *                    terminator, or -1 if an error occurs.
> + */
> +static PRUint32 sip_get_sock_dir_tmpl(char *out, PRUint32 outlen,

For future reference, we use uint32_t.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

Good catch; thanks.  I'll keep the NSPR types encapsulated in future patches.