821848 - PBM - Cannot find text cursor on location bar in private tab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Tetsuharu OHZEKI [:tetsuharu] (UTC+9)]

Environment:
- http://hg.mozilla.org/mozilla-central/rev/b11065872128
- Xperia arc (ICS, sony build)

Step to reproduce:
1) Open a private tab.
2) Focus on location bar in the private tab.

Result:
I cannot find text cursor in location bar.
The color of cursor is black, so the cursor is buried in background color.

Comment 1

[Aaron Train [:aaronmt]]

Needs a beta assignee

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This works. Somehow.

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/78a089f382f9

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/78a089f382f9

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 719608 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Private Browsing
User impact if declined: user unable to "see" the blinking text caret (cursor) in the URLbar when in private browsing mode
Testing completed (on m-c, etc.): it's on m-c now
Risk to taking this patch (and alternatives if risky): seems low risk
String or UUID changes made by this patch: none

Comment 6

[bhavana bajaj [:bajaj]]

Comment on attachment 719608 [details] [diff] [review]
Patch

Low risk uplift of a minor user annoyance. PLease make sure to land before 3/5(tomorrow) for it to make to FX 20 beta 3(going to build tomorrow)

Comment 7

[Sriram Ramasubramanian [:sriram]]

Aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/6f665ab436bc

Comment 8

[Sriram Ramasubramanian [:sriram]]

Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/9f3e30ef4af5

Comment 9

[Aaron Train [:aaronmt]]

Looks good on trunk

Comment 10

[Paul Feher]

Verified on Firefox for Android 21.0b6 using: Nexus 4 (4.2.2)