821876 - Fix ParseNumber so that it accepts a null defaultRegion.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P1)

Description

[Nivi]

The ParseNumber method in PhoneNumber.jsm (http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumber.jsm#298)doesn't handle the case where defaultRegion is null.

The bug was uncovered when the mcc we were using came from the test equipment and didn't match any in the mcc table(MCC_ISO3166_TABLE). Because of that, the country code passed in here - http://mxr.mozilla.org/mozilla-central/source/dom/phonenumberutils/PhoneNumberUtils.jsm#56 is null.
In such a scenario, it is seen that import sim contacts fails and contacts are not imported.

Comment 1

[Anshul]

To add to what Nivi mentioned, this is failing a GCF test case.

Comment 2

[Gregor Wagner [:gwagner]]

(In reply to Anshul from comment #1)
> To add to what Nivi mentioned, this is failing a GCF test case.

What is a GCF test case?

Comment 3

[Michael Vines [:m1] [:evilmachines]]

It's a device certification test suite.

Comment 4

[Gregor Wagner [:gwagner]]

Attachment: patch

Comment 5

[Andreas Gal :gal]

Comment on attachment 693202 [details] [diff] [review]
patch

Make the comment a little clearer.

Comment 6

[Andreas Gal :gal]

Great bug report and diagnosis. ++nsarkar

Comment 7

[Gregor Wagner [:gwagner]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79a8d91ba1cb

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/79a8d91ba1cb

Comment 9

[Gregor Wagner [:gwagner]]

Also fixed upstream:
https://github.com/andreasgal/PhoneNumber.js/commit/d457798ca90451a212ce8ab37b6d7d0c79180589

Comment 10

[Nivi]

Verified the fix. Works correctly now. Thanks.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/63d5c5092a90
https://hg.mozilla.org/releases/mozilla-b2g18/rev/c162f06e2fa4