821960 - Setting expandos on SVGAnimatedAngle.baseVal/animVal does not work because they return new object every time

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

Is this what you're looking for?

Comment 2

[David Zbarsky (:dzbarsky)]

Comment on attachment 692602 [details] [diff] [review]
patch

This should do it.  Is it really worth it to use a tearoff table instead of just storing the baseval/animval in the class?  Note that SVGAnimatedTransformList does the latter.

Also, this will conflict with a lot of the patches for bug 816778.

Comment 3

[Robert Longson [:longsonr]]

Other SVG content classes do this nsSVGLength2 and the length list classes.

We used to store the base/anim val in classes but moved away from that between Firefox 3.6 and Firefox 4.

Comment 4

[Jonathan Watt [:jwatt]]

(In reply to David Zbarsky (:dzbarsky) from comment #2)
> Is it really worth it to use a tearoff table instead of
> just storing the baseval/animval in the class?

Yes. There are a lot of them, and having them all stored in the element classes would add a lot of bloat.

Comment 5

[Robert Longson [:longsonr]]

https://tbpl.mozilla.org/?tree=Try&rev=c393aa115dc8

Comment 6

[Robert Longson [:longsonr]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/60d6ae8c01ef

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/60d6ae8c01ef