Closed Bug 821960 Opened 7 years ago Closed 7 years ago

Setting expandos on SVGAnimatedAngle.baseVal/animVal does not work because they return new object every time

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20

People

(Reporter: dzbarsky, Assigned: longsonr)

Details

Attachments

(1 file)

No description provided.
Attached patch patchSplinter Review
Is this what you're looking for?
Assignee: nobody → longsonr
Attachment #692602 - Flags: review?(jwatt)
Attachment #692602 - Flags: feedback?(dzbarsky)
Comment on attachment 692602 [details] [diff] [review]
patch

This should do it.  Is it really worth it to use a tearoff table instead of just storing the baseval/animval in the class?  Note that SVGAnimatedTransformList does the latter.

Also, this will conflict with a lot of the patches for bug 816778.
Attachment #692602 - Flags: feedback?(dzbarsky) → feedback+
Other SVG content classes do this nsSVGLength2 and the length list classes.

We used to store the base/anim val in classes but moved away from that between Firefox 3.6 and Firefox 4.
(In reply to David Zbarsky (:dzbarsky) from comment #2)
> Is it really worth it to use a tearoff table instead of
> just storing the baseval/animval in the class?

Yes. There are a lot of them, and having them all stored in the element classes would add a lot of bloat.
Attachment #692602 - Flags: review?(jwatt) → review+
https://hg.mozilla.org/mozilla-central/rev/60d6ae8c01ef
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.