82197 - Acct Central Offline Settings should go to Offline panel.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P2)

Description

[laurel]

Using may22 commercial trunk build

The Offline Settings link in the Account Central/account level page in the mail
window should land on the selected account's Offline & Disk Space panel in the
account settings dialog.  Currently it lands at the selected account level panel.

Comment 1

[racham]

That's right. I may have to change the way AccountManager window is opened (not 
just based on the server type like it does today) so that individual items under 
a given account can be selected. Accepting.

Comment 2

[scottputterman]

moving to 0.9.2

Comment 3

[grylchan]

*** Bug 82491 has been marked as a duplicate of this bug. ***

Comment 4

[scottputterman]

moving to 0.9.3

Comment 5

[scottputterman]

reassigning to chuang

Comment 6

[chuang]

Attachment: Patch for the fix

Comment 7

[chuang]

Passing the page xul file name in ViewSetting() or MsgAccountManager(), we can 
select the page we want.  Passing null will open the main page for the selected 
server in folder pane.

Comment 8

[racham]

Patch looks good.

Please change 
+  children = selectServer.childNodes;
to
+  var children = selectServer.childNodes;

Also, this will the good time to add comments on the top of MsgAccountManager()
in accountUtils.js explaining the param(s).

Please take care of those and run couple of tests.

r=bhuvan.

Comment 9

[chuang]

Attachment: New patch with added comment and 'var' declaration

Comment 10

[Scott MacGregor]

sr=mscott

Comment 11

[chuang]

Fix checked into trunk.

Comment 12

[chuang]

Mark fixed

Comment 13

[grylchan]

Using commercial trunk builds:
2001080203 NT 4.0
2001080208 linux 2.2
2001080208 mac 9.0.4

Verified clicking on offline settings, in account
central, will now take you to that accounts Offline and Disk Space
pref panel. Tested this on imap accounts, webmail, and newsgroups.
Tested both Modern and Classic theme also.

Marking as verified.