Closed Bug 821977 Opened 7 years ago Closed 7 years ago

ObjectWrapper.jsm needs to provide |type| property for the new blob

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla20
Tracking Status
firefox19 --- fixed
firefox20 --- fixed
b2g18 --- fixed

People

(Reporter: airpingu, Assigned: airpingu)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Attachment #692568 - Flags: review?(jonas)
Let's see try result first before checking: https://tbpl.mozilla.org/?tree=Try&rev=2d036c027a46, although it's unlikely to cause any harm.
Hi Jonas, do we need to consider this as bb+?
blocking-basecamp: --- → ?
(In reply to Gene Lian [:gene] from comment #2)
> Let's see try result first before checking:
> https://tbpl.mozilla.org/?tree=Try&rev=2d036c027a46, although it's unlikely
> to cause any harm.

All green!
Keywords: checkin-needed
Comment on attachment 692568 [details] [diff] [review]
Patch

Review of attachment 692568 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if it's blocking, but it's definitely safe enough to uplift.

It might very well have bad effects for end users since we use the type of the blob when a blob is shared over bluetooth.
Attachment #692568 - Flags: approval-mozilla-b2g18+
Attachment #692568 - Flags: approval-mozilla-aurora+
Removing nomination for now. Feel free to renominate if you think it's important.
blocking-basecamp: ? → ---
https://hg.mozilla.org/mozilla-central/rev/86e0432487a7
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.