821977 - ObjectWrapper.jsm needs to provide |type| property for the new blob

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Gene Lian (I already quit Mozilla)]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=821633#c7.

Comment 1

[Gene Lian (I already quit Mozilla)]

Attachment: Patch

Comment 2

[Gene Lian (I already quit Mozilla)]

Let's see try result first before checking: https://tbpl.mozilla.org/?tree=Try&rev=2d036c027a46, although it's unlikely to cause any harm.

Comment 3

[Gene Lian (I already quit Mozilla)]

Hi Jonas, do we need to consider this as bb+?

Comment 4

[Gene Lian (I already quit Mozilla)]

(In reply to Gene Lian [:gene] from comment #2)
> Let's see try result first before checking:
> https://tbpl.mozilla.org/?tree=Try&rev=2d036c027a46, although it's unlikely
> to cause any harm.

All green!

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 692568 [details] [diff] [review]
Patch

Review of attachment 692568 [details] [diff] [review]:
-----------------------------------------------------------------

I don't know if it's blocking, but it's definitely safe enough to uplift.

It might very well have bad effects for end users since we use the type of the blob when a blob is shared over bluetooth.

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Removing nomination for now. Feel free to renominate if you think it's important.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/86e0432487a7

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/86e0432487a7

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cb4021304583
https://hg.mozilla.org/releases/mozilla-b2g18/rev/db4a9ec36559