822025 - nsCSSFrameConstructor.cpp:9752:7: warning: variable 'wrapperType' is used uninitialized whenever switch default is taken

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

I'm getting the following warning building nsCSSFrameConstructor.cpp:

nsCSSFrameConstructor.cpp:9752:7: warning: variable 'wrapperType' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
      default:
      ^~~~~~~
nsCSSFrameConstructor.cpp:9757:60: note: uninitialized use occurs here
    const PseudoParentData& pseudoData = sPseudoParentData[wrapperType];
                                                           ^~~~~~~~~~~
nsCSSFrameConstructor.cpp:9734:5: note: variable 'wrapperType' is declared here
    ParentType wrapperType;
    ^

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 692628 [details] [diff] [review]
patch

r=me, I guess, but does using MOZ_NOT_REACHED instead of NS_NOTREACHED shut up the warning too?  If so, I'd vastly prefer that....

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to Boris Zbarsky (:bz) from comment #2)
> does using MOZ_NOT_REACHED instead of NS_NOTREACHED shut
> up the warning too?  If so, I'd vastly prefer that....

Nice. It does indeed, so that's what I pushed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd106eee315

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5dd106eee315