bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

nsCSSFrameConstructor.cpp:9752:7: warning: variable 'wrapperType' is used uninitialized whenever switch default is taken

RESOLVED FIXED in mozilla20

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

Trunk
mozilla20
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
I'm getting the following warning building nsCSSFrameConstructor.cpp:

nsCSSFrameConstructor.cpp:9752:7: warning: variable 'wrapperType' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
      default:
      ^~~~~~~
nsCSSFrameConstructor.cpp:9757:60: note: uninitialized use occurs here
    const PseudoParentData& pseudoData = sPseudoParentData[wrapperType];
                                                           ^~~~~~~~~~~
nsCSSFrameConstructor.cpp:9734:5: note: variable 'wrapperType' is declared here
    ParentType wrapperType;
    ^
(Assignee)

Comment 1

6 years ago
Created attachment 692628 [details] [diff] [review]
patch
Attachment #692628 - Flags: review?(bzbarsky)
Comment on attachment 692628 [details] [diff] [review]
patch

r=me, I guess, but does using MOZ_NOT_REACHED instead of NS_NOTREACHED shut up the warning too?  If so, I'd vastly prefer that....
Attachment #692628 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 years ago
(In reply to Boris Zbarsky (:bz) from comment #2)
> does using MOZ_NOT_REACHED instead of NS_NOTREACHED shut
> up the warning too?  If so, I'd vastly prefer that....

Nice. It does indeed, so that's what I pushed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/5dd106eee315
(Assignee)

Updated

6 years ago
Assignee: nobody → jwatt

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/5dd106eee315
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.