822029 - Update Valgrind tbpl builds to use XPCOM_CC_RUN_DURING_SHUTDOWN=1

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Valgrind detects a leak of 576 bytes (direct) with nsXBLBinding::GenerateAnonymousContent on the stack, see attached snippet which comes from:

https://tbpl.mozilla.org/php/getParsedLog.php?id=17969239&tree=Firefox&full=1

Guessing Core: DOM, please change component if necessary.

Regression window: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b11065872128&tochange=5ea1c76e4bb3

This seems 32-bit only, not showing up on 64-bit builds.

Is this related to bug 818739, where we do not CC on shutdown?

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: 3 more stacks

Adding 3 possibly-related stacks involving:

nsTextControlFrame::CreateAnonymousContent
nsDocumentViewer::InitPresentationStuff
nsNavBookmarks::ResultNodeForContainer

Comment 2

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

We do leak now plenty of stuff when shutting down opt builds.
If you want to do leak testing, set XPCOM_CC_RUN_DURING_SHUTDOWN environment variable or use
debug builds.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to Olli Pettay [:smaug] from comment #2)
> We do leak now plenty of stuff when shutting down opt builds.
> If you want to do leak testing, set XPCOM_CC_RUN_DURING_SHUTDOWN environment
> variable or use
> debug builds.

These appear on TBPL opt builds run under Valgrind - so no debug builds.

Is the following command correct?

export XPCOM_CC_RUN_DURING_SHUTDOWN=yes

Comment 4

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

I'd use =1 but that shouldn't matter. Any value is ok.

Comment 5

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Taking. Patch coming up.

Comment 6

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: patch v1

Sets XPCOM_CC_RUN_DURING_SHUTDOWN=1 prior to execution of PGO tests on Valgrind tbpl builds.

Comment 7

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Hopefully the env variable makes the leak to disappear :)

Comment 8

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

http://hg.mozilla.org/build/tools/rev/56ed45d8d7ad

Comment 9

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This worked properly! We now have green builds again..

https://tbpl.mozilla.org/?noignore=1&jobname=valgrind&rev=c8a1314aa449