Closed
Bug 822042
Opened 13 years ago
Closed 13 years ago
IonMonkey: the spewer will occasionally spew uninitialized memory
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file)
|
928 bytes,
patch
|
evilpies
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #692643 -
Flags: review?(evilpies)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 692643 [details] [diff] [review]
/home/mrosenberg/patches/noUninitialized-r0.patch
Review of attachment 692643 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/JSONSpewer.cpp
@@ +259,5 @@
> if (def->range()) {
> Sprinter sp(GetIonContext()->cx);
> sp.init();
> def->range()->print(sp);
> + stringProperty("type", "%s : blah", sp.string());
Like on mentioned on IRC, this was probably intended to be:
stringProperty("type", "%s : %s", sp.string(), StringFromMIRType(def->type()));
Attachment #692643 -
Flags: review?(evilpies) → review+
|
Reporter | |
Comment 2•13 years ago
|
||
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in
before you can comment on or make changes to this bug.
Description
•