Background compilation broke JIT Inspector ion profiling

RESOLVED FIXED in mozilla20

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: evilpie, Assigned: bhackett)

Tracking

Trunk
mozilla20
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
The ion activity is blank after the 2012-12-14 nightly
Do you get it non-blank in earlier nightlies?  I tried a 2012-12-01 nightly last night, and got blank there too.  :(  But that was using the actual mozilla.org nightly, not my own build, if that matters.
I have no idea what I was seeing in comment 1.  I just re-bisected on nightlies, and the regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4dfe323a663d&tochange=634180132e68

Sadly it has 200+ changesets in it.  :(
Turning off background ion compilation fixes this, as Brian surmised...
Blocks: 813559
Summary: Something broke JIT Inspector ion profiling → Background compilation broke JIT Inspector ion profiling
(Assignee)

Comment 4

6 years ago
Posted patch patchSplinter Review
We attach Ion profiling information to scripts during code generation, which happens off thread with background compilation and isn't allowed to mutate VM state.  Right now it just doesn't generate profiles when running off the main thread.  Rather than restructuring this so that we can attach profiles with background compilation, this patch just does compilation on the main thread when we are profiling scripts.
Assignee: general → bhackett1024
Attachment #693141 - Flags: review?(dvander)
Attachment #693141 - Flags: review?(dvander) → review+
https://hg.mozilla.org/mozilla-central/rev/96de6d7f0813
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
You need to log in before you can comment on or make changes to this bug.