822089 - Background compilation broke JIT Inspector ion profiling

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tom S [:evilpie]]

The ion activity is blank after the 2012-12-14 nightly

Comment 1

[Boris Zbarsky [:bzbarsky]]

Do you get it non-blank in earlier nightlies?  I tried a 2012-12-01 nightly last night, and got blank there too.  :(  But that was using the actual mozilla.org nightly, not my own build, if that matters.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I have no idea what I was seeing in comment 1.  I just re-bisected on nightlies, and the regression range is http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4dfe323a663d&tochange=634180132e68

Sadly it has 200+ changesets in it.  :(

Comment 3

[Boris Zbarsky [:bzbarsky]]

Turning off background ion compilation fixes this, as Brian surmised...

Comment 4

[Brian Hackett [Laid off!]]

Attachment: patch

We attach Ion profiling information to scripts during code generation, which happens off thread with background compilation and isn't allowed to mutate VM state.  Right now it just doesn't generate profiles when running off the main thread.  Rather than restructuring this so that we can attach profiles with background compilation, this patch just does compilation on the main thread when we are profiling scripts.

Comment 5

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96de6d7f0813

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/96de6d7f0813