822108 - webapps-zip.js include too many things

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 692757 [details] [diff] [review]
Patch

Review of attachment 692757 [details] [diff] [review]:
-----------------------------------------------------------------

Please at least update EXTENSIONS_WHITELIST.

::: build/webapp-zip.js
@@ -151,4 @@
>    // Put shared files, but copy only files actually used by the webapp.
>    // We search for shared file usage by parsing webapp source code.
>    let EXTENSIONS_WHITELIST = ['js', 'htm', 'html', 'css'];
> -  let SHARED_USAGE = /shared\/([^\/]+)\/([^''\s]+)("|')/g;

Wouldn't it be safier to just update camera and emergency-call apps to avoid using '..' ? It feels like it works unintentionally.

@@ -170,3 @@
>        return file.isFile() && EXTENSIONS_WHITELIST.indexOf(extension) != -1;
>      }).
>      forEach(function(file) {

Instead of doing this, you should update the EXTENSIONS_WHITELIST array.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/236b0a08c3774f99ed833972898c550077a979eb

Comment 4

[amiller]

Device: Unagi
Build: 20130112070202
White list implemented .