822149 - Image document background is a mostly-transparent PNG against a background color

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Jesse Ruderman]

url("chrome://global/skin/media/imagedoc-darknoise.png") repeat scroll 0% 0% rgb(34, 34, 34)

http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/pinstripe/global/media/imagedoc-darknoise.png

It might be faster to tile a non-transparent PNG instead.  darknoise.png is never used with any other background color, as far as I can tell.

Comment 1

[Justin Dolske [:Dolske]]

Yeah, we should just pre-composite the image with that background color. (Same visual appearance, just using an RGB PNG instead of RGBA + bg-color).

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Stephen, I can pre-composite the image myself, or would you prefer to do it? I remember you mentioned wanting to look in to fixing the repeating pattern of the texture.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: New image from Stephen

Stephen provided me the image over IRC.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

The background-color isn't necessary anymore since the image is now opaque.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch v.1

Also updated the reftests and updated TopLevelVideoDocument.css to use the same image.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21c6e8366bce

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21c6e8366bce