822199 - Remove transition workaround of bug 780692

Status: RESOLVED DUPLICATE of bug 833454

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Bug 803447 introduces a workaround to bug 780692. It should be removed.

https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/window_manager.js#L347-351

Super easy.

Comment 1

[Pranav Ravichandran [:pranavrc]]

Pull request sent

Comment 2

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Attachment: Github: https://github.com/mozilla-b2g/gaia/pull/7038

https://github.com/mozilla-b2g/gaia/pull/7038

Thanks, but you would need to change a few things

1. Use "Bug 822199 - Remove transition workaround of bug 780692" as commit message; don't replace "Bug" with hashes
2. We still need L350 :-P
3. Have you manually test your code? You should do that before submitting the pull request. The code path in question is app-to-app transitions.


Please amend your commit and force push to update the pull request (git commit --amend; git push -f origin master). You should also consider not to use your master branch for submitting pull requests -- people manage multiple branches the same time in the GIT(TM) way!

Comment 3

[Pranav Ravichandran [:pranavrc]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #2)
> Created attachment 692918 [details]
> Github: https://github.com/mozilla-b2g/gaia/pull/7038
> 
> https://github.com/mozilla-b2g/gaia/pull/7038
> 
> Thanks, but you would need to change a few things
> 
> 1. Use "Bug 822199 - Remove transition workaround of bug 780692" as commit
> message; don't replace "Bug" with hashes
> 2. We still need L350 :-P
> 3. Have you manually test your code? You should do that before submitting
> the pull request. The code path in question is app-to-app transitions.
> 
> 
> Please amend your commit and force push to update the pull request (git
> commit --amend; git push -f origin master). You should also consider not to
> use your master branch for submitting pull requests -- people manage
> multiple branches the same time in the GIT(TM) way!

Sorry about that, I'm on a bad internet connection for a short while, so I just edited it through github and sent a pull request. I'll build gaia and test it out. Just a question - what's the total size of the dependencies that gaia needs to download for building?

Comment 4

[David Scravaglieri [:scravag]]

Ask for Vivien approval please.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Pranav Ravichandran [:pranavrc] from comment #3)
> Sorry about that, I'm on a bad internet connection for a short while, so I
> just edited it through github and sent a pull request. I'll build gaia and
> test it out. Just a question - what's the total size of the dependencies
> that gaia needs to download for building?

Depends ... You would need to check out Gaia, download B2G Desktop.
during the make process, Gaia make file will download xulrunner also.

Please ping people on irc #gaia channel for detail.

Please set the review flag again once you are done so I won't missed it.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

That part have since removed in bug 833454