The default bug view has changed. See this FAQ.

Change nsAbView.cpp to use DebugOnly.h instead of Util.h

VERIFIED FIXED in Thunderbird 20.0

Status

MailNews Core
Address Book
--
blocker
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: mconley, Assigned: Ian Neal)

Tracking

Trunk
Thunderbird 20.0

SeaMonkey Tracking Flags

(seamonkey2.17 fixed)

Details

Attachments

(1 attachment)

Bug 820570 moved DebugOnly from Util.h into DebugOnly.h.

This is causing build-breakage for us. We simply need to switch us over to using DebugOnly.h.
(Assignee)

Comment 1

4 years ago
Created attachment 692965 [details] [diff] [review]
Switch from Util.h to DebugOnly.h [Checked in: Comment 7]

This uses the same format as the m-c patch, so puts the new include at the beginning of the file.
Currently testing locally and then will push to try.
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #692965 - Flags: review?(mconley)
(Assignee)

Comment 2

4 years ago
Moving to MailNews Core.
Severity: normal → blocker
Component: Address Book → Address Book
Product: Thunderbird → MailNews Core
Hardware: x86 → All
Version: 20 → Trunk
Comment on attachment 692965 [details] [diff] [review]
Switch from Util.h to DebugOnly.h [Checked in: Comment 7]

Review of attachment 692965 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect. Thanks Ian!
Attachment #692965 - Flags: review?(mconley) → review+
FWIW, this patch fixed my busted build.

Comment 5

4 years ago
Do we need a mailnews peer review here?
Keywords: checkin-needed
I think it just needs to land. I'll do it.
Landed on comm-central as https://hg.mozilla.org/comm-central/rev/8b55bdd4b0a3
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 20.0
(Assignee)

Updated

4 years ago
status-seamonkey2.17: --- → fixed
(Assignee)

Comment 8

4 years ago
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3a140ce538e5
No bustage and fails are already known.
(Assignee)

Updated

4 years ago
Attachment #692965 - Attachment description: Switch from Util.h to DebugOnly.h → Switch from Util.h to DebugOnly.h [Checked in: Comment 7]

Comment 9

4 years ago
Worked for me on Linux.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.