Last Comment Bug 822263 - Change nsAbView.cpp to use DebugOnly.h instead of Util.h
: Change nsAbView.cpp to use DebugOnly.h instead of Util.h
Status: VERIFIED FIXED
:
Product: MailNews Core
Classification: Components
Component: Address Book (show other bugs)
: Trunk
: All All
: -- blocker (vote)
: Thunderbird 20.0
Assigned To: Ian Neal
:
:
Mentors:
Depends on:
Blocks: 820570
  Show dependency treegraph
 
Reported: 2012-12-17 07:23 PST by Mike Conley (:mconley)
Modified: 2012-12-17 13:18 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed


Attachments
Switch from Util.h to DebugOnly.h [Checked in: Comment 7] (1.33 KB, patch)
2012-12-17 08:19 PST, Ian Neal
mconley: review+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) 2012-12-17 07:23:20 PST
Bug 820570 moved DebugOnly from Util.h into DebugOnly.h.

This is causing build-breakage for us. We simply need to switch us over to using DebugOnly.h.
Comment 1 Ian Neal 2012-12-17 08:19:05 PST
Created attachment 692965 [details] [diff] [review]
Switch from Util.h to DebugOnly.h [Checked in: Comment 7]

This uses the same format as the m-c patch, so puts the new include at the beginning of the file.
Currently testing locally and then will push to try.
Comment 2 Ian Neal 2012-12-17 08:20:17 PST
Moving to MailNews Core.
Comment 3 Mike Conley (:mconley) 2012-12-17 08:22:43 PST
Comment on attachment 692965 [details] [diff] [review]
Switch from Util.h to DebugOnly.h [Checked in: Comment 7]

Review of attachment 692965 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect. Thanks Ian!
Comment 4 Mike Conley (:mconley) 2012-12-17 08:38:35 PST
FWIW, this patch fixed my busted build.
Comment 5 :aceman 2012-12-17 12:31:17 PST
Do we need a mailnews peer review here?
Comment 6 Mike Conley (:mconley) 2012-12-17 12:58:08 PST
I think it just needs to land. I'll do it.
Comment 7 Mike Conley (:mconley) 2012-12-17 13:01:54 PST
Landed on comm-central as https://hg.mozilla.org/comm-central/rev/8b55bdd4b0a3
Comment 8 Ian Neal 2012-12-17 13:08:48 PST
https://tbpl.mozilla.org/?tree=Thunderbird-Try&rev=3a140ce538e5
No bustage and fails are already known.
Comment 9 :aceman 2012-12-17 13:18:06 PST
Worked for me on Linux.

Note You need to log in before you can comment on or make changes to this bug.