822265 - BaselineCompiler: JSOP_NEG with double

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: trunk patch for masm.negateDouble

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: baseline patch

This is for ss-3d-morph. But we still need TypeUpdate and UseCount stubs.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 692943 [details] [diff] [review]
trunk patch for masm.negateDouble

Review of attachment 692943 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/ion/arm/MacroAssembler-arm.cpp
@@ +67,5 @@
>  
>  void
> +MacroAssemblerARM::negateDouble(FloatRegister reg)
> +{
> +    ma_vneg(input, input);

s/input/reg

Comment 4

[Jan de Mooij [:jandem]]

Comment on attachment 692945 [details] [diff] [review]
baseline patch

Review of attachment 692945 [details] [diff] [review]:
-----------------------------------------------------------------

Cool, thanks for doing this! r=me with comments addressed

::: js/src/ion/BaselineIC.cpp
@@ +985,5 @@
>          // TODO: Discard/replace stubs.
>          return true;
>      }
>  
> +    if (val.isDouble() && res.isDouble() && op == JSOP_NEG) {

Remove this "if", the isNumber() case below handles it.

@@ +999,5 @@
> +        ICUnaryArith_Int32::Compiler compiler(cx, op);
> +        ICStub *int32Stub = compiler.getStub(ICStubSpace::StubSpaceFor(script));
> +        if (!int32Stub)
> +            return false;
> +        stub->addNewStub(int32Stub);

"return true;" here, so that we don't add two stubs.

@@ +1003,5 @@
> +        stub->addNewStub(int32Stub);
> +    }
> +
> +    if (val.isNumber() && res.isNumber() && op == JSOP_NEG) {
> +        ICUnaryArith_Double::Compiler compiler(cx, op);

Can you add a stub->unlinkStubsWithKind(ICStub::UnaryArith_Int32); here? The double stub handles both cases, so we should just use that, and it doesn't really matter for type information (Ion will specialize as double anyway).

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5589176b4f58

Comment 6

[Tom S. (please needinfo tschuster)]

Forgot to put leave open in there.

Comment 7

[Tom S. (please needinfo tschuster)]

https://hg.mozilla.org/projects/ionmonkey/rev/38d60bed7b75