Closed Bug 822284 Opened 12 years ago Closed 6 years ago

Intermittent browser_privatebrowsing_cookieacceptdialog.js, browser_privatebrowsing_crh.js | Found an unexpected browser window at the end of test run

Categories

(Firefox :: Private Browsing, defect, P3)

Product:
Firefox
Component:
Private Browsing
Platform:
x86_64
macOS
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE
Milestone:
Firefox 20

People

(Reporter: emorley, Assigned: raymondlee)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure, Whiteboard: [leave open])

Attachments

(1 file, 3 obsolete files)

v3
5.29 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test mochitest-browser-chrome on 2012-12-15 18:35:07 PST for push 583b6c704134

slave: talos-r4-snow-074

https://tbpl.mozilla.org/php/getParsedLog.php?id=17987450&tree=Mozilla-Inbound

{
TEST-START | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js
2012-12-15 18:40:24.360 firefox-bin[400:903] invalid drawable
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
2012-12-15 18:40:24.438 firefox-bin[400:903] invalid drawable
Sat Dec 15 18:40:24 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: _CGSFindSharedWindow: WID -1
Sat Dec 15 18:40:24 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorFailure: Set a breakpoint @ CGErrorBreakpoint() to catch errors as they are logged.
Sat Dec 15 18:40:24 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: CGSCopyWindowProperty
Sat Dec 15 18:40:24 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: CGSGetWindowProperty
Sat Dec 15 18:40:24 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: windowGroup: error getting ordering group property
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | The remember checkbox should exist
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | The checkbox should be disabled
2012-12-15 18:40:24.862 firefox-bin[400:903] invalid drawable
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
2012-12-15 18:40:24.979 firefox-bin[400:903] invalid drawable
Sat Dec 15 18:40:25 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: _CGSFindSharedWindow: WID -1
Sat Dec 15 18:40:25 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: CGSCopyWindowProperty
Sat Dec 15 18:40:25 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: CGSGetWindowProperty
Sat Dec 15 18:40:25 talos-r4-snow-074.build.scl1.mozilla.com firefox-bin[400] <Error>: kCGErrorIllegalArgument: windowGroup: error getting ordering group property
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | The remember checkbox should exist
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | The checkbox should not be disabled
INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | finished in 818ms
TEST-INFO | checking window state
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | Found an unexpected browser window at the end of test run
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js | must wait for focus
TEST-START | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js
2012-12-15 18:40:25.398 firefox-bin[400:903] invalid drawable
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | The clear recent history command should exist
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | PrivateBrowsingUtils should report the correct per-window private browsing status
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Clear Recent History command should be disabled according to the private browsing mode
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Console message: [JavaScript Error: "TypeError: aUrl is undefined" {file: "chrome://browser/content/urlbarBindings.xml" line: 642}]
2012-12-15 18:40:25.722 firefox-bin[400:903] invalid drawable
TEST-INFO | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Console message: OpenGL LayerManager Initialized Succesfully.
Version: 2.1 NVIDIA-1.6.36
Vendor: NVIDIA Corporation
Renderer: NVIDIA GeForce 320M OpenGL Engine
FBO Texture Target: TEXTURE_2D
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | The clear recent history command should exist
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | PrivateBrowsingUtils should report the correct per-window private browsing status
TEST-PASS | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Clear Recent History command should be disabled according to the private browsing mode
INFO TEST-END | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | finished in 732ms
TEST-INFO | checking window state
TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js | Found an unexpected browser window at the end of test run
}
Blocks: 806682
Ehsan, please may you take a look at this?

At the moment, the failure rate of this test is high enough that it will be one of the ones disabled for too many intermittent failures, once I return from vacation in a few days time.

Cheers :-)
Flags: needinfo?(ehsan)
The test changes are so simple that I went ahead and landed this to speed up the process.

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8971a203a0e
(In reply to Josh Matthews [:jdm] from comment #13)
> The test changes are so simple that I went ahead and landed this to speed up
> the process.
> 
> https://hg.mozilla.org/integration/mozilla-inbound/rev/c8971a203a0e

jdm += 10;
Flags: needinfo?(ehsan)
https://hg.mozilla.org/mozilla-central/rev/c8971a203a0e
Assignee: nobody → josh
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Thank you for doing that Josh :-)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Failure rate too high; disabled on OS X for now:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3d89d6870e6
Whiteboard: [test disabled on OS X][leave open]
Andres, can you please take a look at this?  Thanks!
Assignee: josh → andres
Blocks: pbngentest
Status: REOPENED → ASSIGNED
Attached patch Patch v1 (obsolete) — — Splinter Review 
A new attempt to fix the issues.

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=011adeea9fd3
Attachment #696748 - Attachment is obsolete: true
Attachment #702140 - Flags: review?(ehsan)
Attachment #702140 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/41b70a63b036
Whiteboard: [test disabled on OS X][leave open]
:-(
Shoot, this is not fixed yet.  Andres, can you please take another look?

Ed, if this starts to fail too often again, please feel free to disable it temporarily again.  Sorry!
Whiteboard: [leave open]
S'ok was more of an empathy sad face than anything else :-)
Any updates on this?
Attached patch Patch v2 (obsolete) — — Splinter Review 
All green on try: https://tbpl.mozilla.org/?tree=Try&rev=e46e91a8028e
Attachment #709348 - Flags: review?(ehsan)
Attachment #709348 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/mozilla-central/rev/4466d3ff8ada
Status: ASSIGNED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee: andres → raymond
Disabled again on OS X until this is fixed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1706b098cda7
Whiteboard: [test disabled on OS X][leave open]
Attached patch v3 — — Splinter Review 
Another attempt to fix it.

Pushed to try and waiting
https://tbpl.mozilla.org/?tree=Try&rev=a23fd4ec2513
Attachment #702140 - Attachment is obsolete: true
Attachment #709348 - Attachment is obsolete: true
Attachment #711220 - Flags: review?(josh)
(In reply to Raymond Lee [:raymondlee] from comment #190)
> Created attachment 711220 [details] [diff] [review]
> v3
> 
> Another attempt to fix it.
> 
> Pushed to try and waiting
> https://tbpl.mozilla.org/?tree=Try&rev=a23fd4ec2513

Looks fine on mac osx
Given this is intermittent, a single green result isn't conclusive, so I've retriggered a number of OS X browser-chrome jobs on that Try push to hopefully give a higher level of confidence.
For the record, doing full pushes like that isn't necessary and tends to burn up shared resources. It's much better to retrigger individual test suites as needed, by pressing the + link in the bottom left with a build selected.
(In reply to Josh Matthews [:jdm] from comment #204)
> For the record, doing full pushes like that isn't necessary and tends to
> burn up shared resources. It's much better to retrigger individual test
> suites as needed, by pressing the + link in the bottom left with a build
> selected.

Thanks for the tip.  However, I don't think I have a user name and password for the LDAP authentication.
(In reply to Raymond Lee [:raymondlee] from comment #205)
> (In reply to Josh Matthews [:jdm] from comment #204)
> > For the record, doing full pushes like that isn't necessary and tends to
> > burn up shared resources. It's much better to retrigger individual test
> > suites as needed, by pressing the + link in the bottom left with a build
> > selected.
> 
> Thanks for the tip.  However, I don't think I have a user name and password
> for the LDAP authentication.

You should file a bug in mozilla.org::Server Operations in order to get one.
Comment on attachment 711220 [details] [diff] [review]
v3

Review of attachment 711220 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_cookieacceptdialog.js
@@ +116,5 @@
>            selectedBrowser.loadURI(BLANK_URL);
>            return;
>          }
>          selectedBrowser.removeEventListener("load", onLoad, true);
> +        executeSoon(function() aCallback(aWin));

This seems like the only real change here, as I noted in the other file.  So I can't see how this patch could fix the crh intermittent failures...  Can you please split this part in a separate patch and enable browser_privatebrowsing_cookieacceptdialog.js and continue to investigate the other test?

Thanks!

::: browser/components/privatebrowsing/test/browser/perwindow/browser_privatebrowsing_crh.js
@@ -54,2 @@
>          info("Test on public window");
> -        checkDisableOption(false, win, finish);

Are there any actual changes here?  These all seem like variable renamings...
Attachment #711220 - Flags: review?(josh) → review-
The patch does actually switch the order of the privatecand public tests.
(In reply to Josh Matthews [:jdm] from comment #210)
> The patch does actually switch the order of the privatecand public tests.

 Yes, running the public window test first would ensure that the dialog is set and displayed properly before it gets closed.
Comment on attachment 711220 [details] [diff] [review]
v3

I see, makes sense.  Sorry I missed this earlier.  Let's give this a shot!
Attachment #711220 - Flags: review- → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/7af8bba450df
Whiteboard: [test disabled on OS X][leave open] → [leave open]
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Mass-closing old bugs I filed that have not had recent activity/no longer affect me.
Status: REOPENED → RESOLVED
Closed: 11 years ago → 6 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: