822310 - [Gaia] Fix outdated or broken iconography across all Gaia apps and system folders

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Peter La]

After doing a scrub of all the Gaia app and system folders, we've compiled a list of icons that are outdated, unused, or broken (ie. were never designed by the Visual Design team), and placed them in the spreadsheet here:

https://docs.google.com/spreadsheet/ccc?key=0AvIV2XTLJx6ldDRFRWhGcU9WWXM2M2FuRkQ3V0hHbFE#gid=0

This bug is to track the effort to fix all of these icons.  The work will be divided between myself and Eric Pang, and will most likely be submitted as 2 commits to UX branch (1 for each person).

Comment 1

[Peter La]

Fixed in UX branch with

https://github.com/gordonbrander/gaia/pull/62

and

https://github.com/gordonbrander/gaia/pull/63

Sam, when you get a chance, please review. :)  Thanks!

Comment 2

[Peter La]

NOTE***

I found a few more icons we can fix, please don't close this bug until I've attached the pull request numbers.

Comment 3

[Peter La]

This final pull request should completely fix this bug:

https://github.com/gordonbrander/gaia/pull/65

Comment 4

[Sam Joch [:samjoch]]

Landed in UX https://github.com/gordonbrander/gaia/commit/1aa7c38d1c6a41791b7f03c462106b1261212523

I merged all the 3 PRs (62, 63, 65) together.

Comment 5

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Is there a difference between the blue tooth settings ?  It seems that there's a medium blue, light blue and an off setting for blue tooth in the status bar.

Not sure if I see the shadow for the bar or the + in calendar.  I can't seem to find the x for calendar hard to tell any of the shadows for that matter.

Not sure if the drop shadows are in very well...

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To be more specific:
I can't see the drop shadow of the new icons.  I can see in the change (I look at the pull requests specifically so I know what I look for), and I don't see the drop shadow icon (the new version)

Comment 7

[Peter La]

Attachment: Screenshot to show the difference bettween no drop shadow and drop shadow

Hi Naoki,

Apologies for not getting back to you on this.  I've attached a screenshot to help you distinguish between the ones with no dropshadow and the expected versions with drop shadow.  Let me know if this still doesn't clear things up.

Thanks!

Comment 8

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Thanks, Peter!  I see the difference now... very subtle.

Comment 9

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

Comment 10

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Looks like this change is in master, 
Master build : 2013-03-26-07-02-04
"mozilla-central" revision="28b048ffb7a7"
"integration/gaia-central" revision="44f6a17f24d4"
"gecko.git"revision="a800f14ea7022a78966f7fe14a9b0d11c569b151"
"gaia.git" revision="ace1eb32a313da1232bbdf9cff2581a4b036356d"

It doesn't look like it's in v1 train.  I'm looking at the + sign in the header for calendar.

Comment 11

[Stephany Wilkes]

Peter, Sam or Vivien:

Is this ready to raise to approval? with user value and risk in the comments? Let me know. Our goal is to wrap up all Yedo and VxD changes by April 5th. Thanks!

Comment 12

[jachen]

Visual design change requesting trackingb2g18 nom

Comment 13

[Cristian Rodriguez (:crdlc)]

Attachment: Patch: https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: updated iconography across all Gaia apps is very important to have a good UX
Testing completed: yes
Risk to taking this patch (and alternatives if risky): low, changes in css and resources basically
String or UUID changes made by this patch:

Comment 14

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 734509 [details]
Patch: https://github.com/mozilla-b2g/gaia/commit/5cb6a64dbf643e2c8774f4aadedd57a6e0d6dafb

Discussed in triage with Jaime and we're going to take this for uplift since it's been verified on master, but it will (at some point in the next week or so) need verifying on v1-train (esp wrt to l10n). Jaime will work with Tony and Delphine on this.

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Hey John, is this showing up in your uplift queries?  It should be landed to v1-train.

Comment 16

[John Ford [:jhford] CET/CEST Berlin Time]

(In reply to [e-mail] from comment #15)
> Hey John, is this showing up in your uplift queries?  It should be landed to
> v1-train.

Nope,  I'm using the queries from the B2G_Landing wiki page, this bug is not showing up in those.  I was on PTO last week, just getting to this now.  There are merge conflicts with this patch on v1-train.

Asking for a merge from the patch author.

Comment 17

[Cristian Rodriguez (:crdlc)]

I wasn't the author , he was Vivien per comment 9, I just asked for approval

Comment 18

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Cristian Rodriguez (:crdlc) from comment #17)
> I wasn't the author , he was Vivien per comment 9, I just asked for approval

This is pretty old, do we still need to do anything here?

Comment 19

[Josh Schmitt [Joshs]]

Bug is too old to verify on 1.1, does not affect 1.2

Leo v1.1
Environmental Variables
Device: Leo v1.1 Mozilla RIL
Build ID: 20131203041431
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/617eb9d9bcc2
Gaia: 19c9ff3a46a4389e40253c97b359763243af4531
Platform Version: 18.1
Firmware Version: lge_default