Closed
Bug 822350
Opened 12 years ago
Closed 12 years ago
DOM bindings that use FloatingPoint.h methods should #include it
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla20
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
2.73 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
Methods that take restricted doubles check for MOZ_DOUBLE_IS_FINITE, defined in mozilla/FloatingPoint.h. But they don't directly include that header -- instead they bootleg it from who knows where. It makes for nicer bindings-code reading if things include what they use, so we should do that.
Attachment #693011 -
Flags: review?(bzbarsky)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 693011 [details] [diff] [review] Patch r=me
Attachment #693011 -
Flags: review?(bzbarsky) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2e51aa6f606
Target Milestone: --- → mozilla20
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e2e51aa6f606
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•