822364 - Old URL Audit & Resolution

Status: VERIFIED FIXED

(Websites :: Firefox Flicks, defect)

Description

[Ben (:bensternthal)]

Some URLS from the previous year's content should not be reachable.

This bug captures analyzing which urls should be removed and actually removing those urls.

Comment 1

[Osmose [:osmose, :mkelly]]

Current URLs:

/creative
/faq
/judges
/partners
/prizes
/rules

/ (winners page)
/winners
/recent
/video/<video_id>
/add_view
/video/noir
/video/dance
/video/twilight

/users/verify
/users/edit
/users/details/<user_id>
/users/logout
/users/profle
/users

/csp/report
/logout
/admin/**

I suggest we reduce the urls to the following:

/ (new index)
/video/<video_id>
/admin/**

We could modify the existing video table to allow for both old and new entries, and use a field to determine if a video is a vid.ly video or a vimeo video, and show a special archive page for vid.ly videos and the new page for a vimeo vide.

The rest of the URLs would be removed and re-added if we need them for new pages (such as reusing the login urls if we end up requiring a Persona account again).

This is blocked by bug 818524 due to the fact that we cannot release this until the R1 content is done, and bug 818524 is being used to test deployment with chief. Once this change is merged, it will effectively block releases until R1 is complete.

Comment 2

[Ben (:bensternthal)]

Ok I understand your comments, and agree lets wait on making this change until chief is tested and functioning.

Final URL list should come from final design (list of full pages like FAQ & Rules).

Comment 3

[Ben (:bensternthal)]

Doing triage noticed this pull request was closed:

https://github.com/mozilla/firefox-flicks/pull/107

If so should we resolve this bug.

Comment 4

[Osmose [:osmose, :mkelly]]

Resolving. Verification steps are to ensure that the URLs above return 404s except for the following:

/
/video/<video_id>
/video/noir
/video/dance
/video/twilight
/admin/** (Only available via VPN appliance on production)

Note that the video pages will probably through a 500 error currently, that is acceptable for this bug and will be fixed by the video page redesign that craig is going to handle.

Comment 5

[Rebecca Billings [:rbillings]]

Verified all except /video/<video_id> as I don't have an id to test with.

Comment 6

[Rebecca Billings [:rbillings]]

Tested with https://firefoxflicks-dev.allizom.org/en-US/video/81, it's all good.