Closed
Bug 822421
Opened 8 years ago
Closed 8 years ago
about:home text illegible on dark Lightweight themes
Categories
(Firefox for Android Graveyard :: Theme and Visual Design, defect)
Tracking
(firefox19 verified, firefox20 verified)
VERIFIED
FIXED
Firefox 20
People
(Reporter: sriram, Assigned: sriram)
References
Details
Attachments
(1 file)
25.36 KB,
patch
|
mfinkle
:
review+
bajaj
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
On dark themes, the text color on about:home is barely readable.
Assignee | ||
Comment 1•8 years ago
|
||
This fixes the problem as the UX suggested colors.
Attachment #693065 -
Flags: review?(mark.finkle)
Comment 2•8 years ago
|
||
Comment on attachment 693065 [details] [diff] [review] Patch Part of me is not happy we need to add so much code. But I guess we need this.
Attachment #693065 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/531d2eb905d7
Updated•8 years ago
|
Assignee: nobody → sriram
Comment 4•8 years ago
|
||
Push backed out for: https://tbpl.mozilla.org/php/getParsedLog.php?id=18097340&tree=Mozilla-Inbound https://hg.mozilla.org/integration/mozilla-inbound/rev/850b6458a7f0 Please try building locally before pushing! :-)
Assignee | ||
Comment 5•8 years ago
|
||
I had triggered a clobber for the same. It's a clobbering issue.
Assignee | ||
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1a7f21d5a95a
Assignee | ||
Comment 7•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/65b79c7b4105
Comment 8•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/65b79c7b4105
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 20
Assignee | ||
Comment 9•8 years ago
|
||
Comment on attachment 693065 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Personas User impact if declined: about:home text is illegible when dark themes are applied. So users cannot sport a Darth Vader theme for Firefox! Testing completed (on m-c, etc.): Landed on m-c yesterday. Risk to taking this patch (and alternatives if risky): Very low. Proven concept of state-list that we use everywhere. String or UUID changes made by this patch: None.
Attachment #693065 -
Flags: approval-mozilla-aurora?
Comment 10•8 years ago
|
||
Comment on attachment 693065 [details] [diff] [review] Patch Approving for aurora given the low risk profile here.
Attachment #693065 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 11•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/GeckoView.java.frag This particular file is needed for this patch to land -- which is currently not available in Aurora. Do I add a trimmed down version of the file as a separate patch for Aurora -- which will be like a pre-requisite for this patch?
Comment 12•8 years ago
|
||
(In reply to Sriram Ramasubramanian [:sriram] from comment #11) > https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/ > GeckoView.java.frag > This particular file is needed for this patch to land -- which is currently > not available in Aurora. Do I add a trimmed down version of the file as a > separate patch for Aurora -- which will be like a pre-requisite for this > patch? The preferred approach would be to create a new version of this patch that does not depend on GeckoView.java.frag changes. We like to avoid pulling in additional changes to aurora if they are not really needed.
Comment 13•8 years ago
|
||
Firefox 20.0a1 (2013-01-02) Device: Galaxy Nexus OS: Android 4.1.1 The text in about:home is not visible (is now white as the wordmark). Verified Fixed for Nightly 20.0a1 Please push it to Aurora too so we close this bug verified for all branches.
status-firefox19:
--- → affected
status-firefox20:
--- → verified
Assignee | ||
Comment 14•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bd9a130677e
Updated•8 years ago
|
Comment 15•8 years ago
|
||
Firefox 19 Beta 1 (2013-01-08) Device: Galaxy Nexus OS:Android 4.1. This was push in beta channel also as Firefox 19 is currently in Beta. As the text is white now I will mark the bug Verified Fixed.
Status: RESOLVED → VERIFIED
Updated•3 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•