822421 - about:home text illegible on dark Lightweight themes

Status: VERIFIED FIXED

(Firefox for Android :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

On dark themes, the text color on about:home is barely readable.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This fixes the problem as the UX suggested colors.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 693065 [details] [diff] [review]
Patch

Part of me is not happy we need to add so much code. But I guess we need this.

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/531d2eb905d7

Comment 4

[Ed Morley [:emorley]]

Push backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=18097340&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/850b6458a7f0

Please try building locally before pushing! :-)

Comment 5

[Sriram Ramasubramanian [:sriram]]

I had triggered a clobber for the same. It's a clobbering issue.

Comment 6

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a7f21d5a95a

Comment 7

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/65b79c7b4105

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/65b79c7b4105

Comment 9

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 693065 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Personas
User impact if declined: about:home text is illegible when dark themes are applied. So users cannot sport a Darth Vader theme for Firefox!
Testing completed (on m-c, etc.): Landed on m-c yesterday.
Risk to taking this patch (and alternatives if risky): Very low. Proven concept of state-list that we use everywhere.
String or UUID changes made by this patch: None.

Comment 10

[bhavana bajaj [:bajaj]]

Comment on attachment 693065 [details] [diff] [review]
Patch

Approving for aurora given the low risk profile here.

Comment 11

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/GeckoView.java.frag
This particular file is needed for this patch to land -- which is currently not available in Aurora. Do I add a trimmed down version of the file as a separate patch for Aurora -- which will be like a pre-requisite for this patch?

Comment 12

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Sriram Ramasubramanian [:sriram] from comment #11)
> https://hg.mozilla.org/mozilla-central/file/tip/mobile/android/base/
> GeckoView.java.frag
> This particular file is needed for this patch to land -- which is currently
> not available in Aurora. Do I add a trimmed down version of the file as a
> separate patch for Aurora -- which will be like a pre-requisite for this
> patch?

The preferred approach would be to create a new version of this patch that does not depend on GeckoView.java.frag changes. We like to avoid pulling in additional changes to aurora if they are not really needed.

Comment 13

[Ioana Chiorean]

Firefox 20.0a1 (2013-01-02)
Device: Galaxy Nexus 
OS: Android 4.1.1 

The text in about:home is not visible (is now white as the wordmark). Verified Fixed for Nightly 20.0a1

Please push it to Aurora too so we close this bug verified for all branches.

Comment 14

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5bd9a130677e

Comment 15

[Ioana Chiorean]

Firefox 19 Beta 1 (2013-01-08)
Device: Galaxy Nexus
OS:Android 4.1.

This was push in beta channel also as Firefox 19 is currently in Beta. As the text is white now I will mark the bug Verified Fixed.