Closed Bug 822487 Opened 7 years ago Closed 7 years ago

Improve CLOBBER instructions and note how to bypass it


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: BenWa, Assigned: Dolske)




(1 file, 2 obsolete files)

Attached patch patch (obsolete) — Splinter Review
Let's provide instructions for people that want to skip the CLOBBER for whatever reasons.

NOTE: Currently 'touch objdir/CLOBBER' works but in the future where we compare the file content this will fail.
Attachment #693156 - Flags: review?(gps)
Comment on attachment 693156 [details] [diff] [review]

Review of attachment 693156 [details] [diff] [review]:


While you're here, perhaps we should also tell people how to clobber (since it may not be obvious to first-time devs). Feel free to punt to a follow-up.
Attachment #693156 - Flags: review?(gps) → review+
Attached patch Now with improved message! (obsolete) — Splinter Review
My build triggered the CLOBBER warning today, and I thought the message could be improved for people who might not know what's going on. Greg pointed out this patch was already floating around, so I just merged the two together with a little extra wordsmithing.

Tested output:
Attachment #693156 - Attachment is obsolete: true
Attachment #697237 - Flags: review?(gps)
Comment on attachment 697237 [details] [diff] [review]
Now with improved message!

Review of attachment 697237 [details] [diff] [review]:

Attachment #697237 - Flags: review?(gps) → review+
markh convinced me that just an obtuse reference to "objdir" might not be enough for the uninitiated.

New output:
Attachment #697237 - Attachment is obsolete: true
Comment on attachment 697245 [details] [diff] [review]
Now with more bikeshedding!

Review of attachment 697245 [details] [diff] [review]:

I saw a red shed and I want it painted black.

@@ +135,4 @@
>      cat $_topsrcdir/CLOBBER | sed '/^#/d' | sed 's/^/	*	/'
> +    echo "	*	"
> +    echo "	*	The easiest way to fix this is to manually delete your objdir:"
> +    echo "	*	rm -rf '$_objdir'"

We don't allow spaces in objdir, so there should be no need to surround in quotes.

Also, |./mach clobber| will do this automatically and is faster on Windows. I'd accept a patch that advertises mach :)
Attachment #697245 - Flags: review+
Assignee: nobody → dolske
OS: Mac OS X → All
Hardware: x86 → All
Summary: Add instruction to bypass CLOBBER → Improve CLOBBER instructions and note how to bypass it
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla20
Depends on: 717372
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.