822487 - Improve CLOBBER instructions and note how to bypass it

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Let's provide instructions for people that want to skip the CLOBBER for whatever reasons.

NOTE: Currently 'touch objdir/CLOBBER' works but in the future where we compare the file content this will fail.

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 693156 [details] [diff] [review]
patch

Review of attachment 693156 [details] [diff] [review]:
-----------------------------------------------------------------

Sure.

While you're here, perhaps we should also tell people how to clobber (since it may not be obvious to first-time devs). Feel free to punt to a follow-up.

Comment 2

[Justin Dolske [:Dolske]]

Attachment: Now with improved message!

My build triggered the CLOBBER warning today, and I thought the message could be improved for people who might not know what's going on. Greg pointed out this patch was already floating around, so I just merged the two together with a little extra wordsmithing.

Tested output: http://www.pastebin.mozilla.org/2034546

Comment 3

[Benoit Girard (:BenWa)]

LGTM

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 697237 [details] [diff] [review]
Now with improved message!

Review of attachment 697237 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Comment 5

[Justin Dolske [:Dolske]]

Attachment: Now with more bikeshedding!

markh convinced me that just an obtuse reference to "objdir" might not be enough for the uninitiated.

New output: http://www.pastebin.mozilla.org/2034609

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 697245 [details] [diff] [review]
Now with more bikeshedding!

Review of attachment 697245 [details] [diff] [review]:
-----------------------------------------------------------------

I saw a red shed and I want it painted black.

::: configure.in
@@ +135,4 @@
>      cat $_topsrcdir/CLOBBER | sed '/^#/d' | sed 's/^/	*	/'
> +    echo "	*	"
> +    echo "	*	The easiest way to fix this is to manually delete your objdir:"
> +    echo "	*	rm -rf '$_objdir'"

We don't allow spaces in objdir, so there should be no need to surround in quotes.

Also, |./mach clobber| will do this automatically and is faster on Windows. I'd accept a patch that advertises mach :)

Comment 7

[Justin Dolske [:Dolske]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0c6811802c54

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0c6811802c54