822526 - Turn Image into an interface

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

We want to be able to wrap images and transform them or add additional behavior. This will be used in the implementation of media fragments in bug 790640. (Almost there!) To do this, Image must be an interface rather than an abstract class, as we need to be able to wrap all Image methods, and the wrappers won't need the state that the current Image abstract class contains.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Turn mozilla::image::Image into an interface.

Here we go.

Comment 2

[Seth Fowler [:seth] [:s2h]]

I pulled this out of a larger patch in case it was controversial. Running a try job on this piece alone to make sure I didn't miss anything: https://tbpl.mozilla.org/?tree=Try&rev=44835893ded2

Comment 3

[Seth Fowler [:seth] [:s2h]]

Attachment: Turn mozilla::image::Image into an interface.

Rebased. Going ahead and requesting review.

Comment 4

[Seth Fowler [:seth] [:s2h]]

The previous try job had a failure that I'm fairly certain was caused by an earlier buggy version of bug 821023. That bug's now fixed. Here's a new try job running against the rebased version: https://tbpl.mozilla.org/?tree=Try&rev=0e8436efeeab

Comment 5

[Joe Drew (not getting mail)]

Comment on attachment 694074 [details] [diff] [review]
Turn mozilla::image::Image into an interface.

Review of attachment 694074 [details] [diff] [review]:
-----------------------------------------------------------------

Not controversial at all!

Comment 6

[Seth Fowler [:seth] [:s2h]]

@Joe: Great! Thanks for the review.

The try job looks good (a few unrelated intermittent oranges, but nothing caused by this patch). Requesting checkin.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4425abacc947

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4425abacc947