822620 - disable Notification Center support for Firefox 19 and 20, it isn't ready

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Josh Aas]

I left Notification Center support enabled in Firefox 19 and 20 on the assumption that the W3C notification work (bug 782211) would complete in those releases. It never happened, so we need to disable our incomplete Notification Center support in Firefox 19 and 20.

Comment 1

[Josh Aas]

Attachment: fix v1.0

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 695273 [details] [diff] [review]
fix v1.0

Review of attachment 695273 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/alerts/mac/nsMacAlertsService.mm
@@ +100,5 @@
>  nsresult
>  nsMacAlertsService::Init()
>  {
> +  // Notification Center support isn't ready, don't use it.
> +  return NS_ERROR_NOT_AVAILABLE;

How about adding a preference and using the new:

 #ifdef RELEASE_BUILD

Comment 3

[Josh Aas]

(In reply to Doug Turner (:dougt) from comment #2)

> How about adding a preference and using the new:
> 
>  #ifdef RELEASE_BUILD

I'm intending for all of it to just get replaced, the feature as I wrote it probably isn't going to be further developed. I don't think we gain anything by letting people turn it on.

Comment 4

[Josh Aas]

Comment on attachment 695273 [details] [diff] [review]
fix v1.0

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 728106
User impact if declined: We'll ship an incomplete Notification Center implementation to users.
Testing completed (on m-c, etc.): This has been disabled on beta for a while now.
Risk to taking this patch (and alternatives if risky): very little risk
String or UUID changes made by this patch: none

Comment 5

[Josh Aas]

m-c try run, os x only:

https://tbpl.mozilla.org/?tree=Try&rev=118b7b2faaa3

Comment 6

[Josh Aas]

pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/c0ba38205c41

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c0ba38205c41

Comment 8

[Josh Aas]

pushed to mozilla-aurora

http://hg.mozilla.org/releases/mozilla-aurora/rev/679426677f68

Comment 9

[u279076]

Not to nitpick, but should the status flags be set to "disabled" in this case?

Additionally, is there anything QA can do to double check this is really disabled?

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

Can we consider this verified based on comment 26 from issue 827979?

Comment 11

[u279076]

I don't use Mac day to day but I don't think Growl and Notification Centre are the same thing. In other words, the verification steps might be the same as bug 827979 but you'd need to test *this* bug with Growl removed and Notification Centre enabled.

Comment 12

[Cornel Ionce [:noni] [Hubs QA]]

Removed Growl and verified that Notification Center does not support Firefox on Mac OSX 10.8 using:
- Firefox 19 RC (build ID: 20130215130331)
- Firefox 20 beta 5 (Build ID:20130313170052).