822636 - [pdfjs] Possible CSP problems

Status: RESOLVED DUPLICATE of bug 966865

(Firefox OS Graveyard :: Gaia::PDF Viewer, defect)

Description

[Carmen Jimenez Cabezas]

I've passed a static analysis on the source code of Gaia looking for possible problems regarding the default CSP. The pdfjs application has the following possible issues:

FILE: content/web/viewer.html

71:        <button id="errorShowMore" onclick="" oncontextmenu="return false;" data-l10n-id="error_more_info">
74:        <button id="errorShowLess" onclick="" oncontextmenu="return false;" data-l10n-id="error_less_info" hidden='true'>
31:    <script type="text/javascript">

Comment 1

[Joshua Smith [:joshua-s]]

Should be fairly easy to fix, can I take this?  (I may need a little help because it is my first B2G bug.)

Comment 2

[Carmen Jimenez Cabezas]

You're right, it should be easy. Go ahead and take it.

Beside the lines reported at the bug description there is another CSP error at line

79 : <button id="errorClose" oncontextmenu="return false;" data-l10n-id="error_close">

of the same file

Comment 3

[Joshua Smith [:joshua-s]]

Ok, I took it :)

Comment 4

[Joshua Smith [:joshua-s]]

What branch should I submit a pull to?

Comment 5

[Antonio Manuel Amaya Calvo (:amac)]

Master

Comment 6

[Joshua Smith [:joshua-s]]

Oh, I just saw that this pull will have to be submitted to the mozilla/pdf.js repository, not the gaia one.

(https://github.com/mozilla-b2g/gaia/blob/master/apps/pdfjs/README.md)

Comment 7

[Carmen Jimenez Cabezas]

Adding someone on cc of the bug that might help you better than me on this.

Comment 8

[Brendan Dahl [:bdahl]]

It'd be best if you could do a pull request to https://github.com/mozilla/pdf.js.git and then we'll upstream the changes to gaia.

Comment 9

[Joshua Smith [:joshua-s]]

Ok, thanks!

Comment 10

[Joshua Smith [:joshua-s]]

Wow, I never got back to you guys on this :/ Is it still an issue?

Comment 11

[Carmen Jimenez Cabezas]

I wouldn't think so. This seems to have been resolved in bug 966865. Closing this as duplicated