82271 - Check Spelling before sending preference not lockable

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect)

Description

[Rodney Velasco]

Prefstring "mail.SpellCheckBeforeSend" in Edit -> Preferences -> Mail and 
Newsgroups -> Message Composition is not lockable. Locking prefs is a new feautre 
implemented last month by [e-mail].  All new general pref elements 
added to prefs window needs to adhere to locking conventions.  The lockPref 
function is used to lock elements in the preference window...
i.e. lockPref("mail.SpellCheckBeforeSend", true)
must be added to a hashed CFG file or all-ns.js or prefs.js file to disable the 
pref.  newsgroup posting on the URL field of this bug and listed below.

news://news.mozilla.org/3AC8F5D2.6CA02623%40netscape.com

Comment 1

[Rodney Velasco]

assigning QA contact to myself.

Comment 2

[Scott MacGregor]

Eddy says he wants this =).

Comment 3

[eddyk]

Attachment: patch to lock spell check button

Comment 4

[eddyk]

Changing from a default disabled state and removing disabled attribute if spell
checker is available, to starting in a non-disabled state and setting the
disabled attribute if the spell check is not available.

This allows the nsPrefWindow code to properly lock the button element when the
pref string is locked.  The previous code had the nsPrefWindow disabling the
button, then the js code enabling it because the spell checker was available.

r and sr needed.

Comment 5

[Scott MacGregor]

r=mscott

Comment 6

[Håkan Waara]

r=hwaara

Comment 7

[Scott MacGregor]

r/sr=mscott

Comment 8

[eddyk]

checked in.  marking fixed.

Comment 9

[Rodney Velasco]

verified on trunk
linux 2001071109
windows 20010071104
mac 2001071208

Comment 10

[Rodney Velasco]

Attachment: Save this as netscape.cfg and place in same dir as netscape binary

Comment 11

[Rodney Velasco]

To test, please download above attachment and save to you mozilla/netscape
application directory, call the file spelllock.cfg.  Add the following lines to
your all.js/all-ns.js (mozilla/netscape respectively):

pref("general.config.filename", "spelllock.cfg");
pref("general.config.vendor", "spelllock");

restart browser and you should see the preference Item unchecked (I specified it
to be false in the CFG) and greyed out.