Closed
Bug 822739
Opened 12 years ago
Closed 12 years ago
DeviceManagerADB.pushDir fails with _useZip
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jgriffin, Assigned: mihneadb)
References
Details
Attachments
(1 file)
|
1.02 KB,
patch
|
jgriffin
:
review+
|
Details | Diff | Splinter Review |
Attempting to use DeviceManagerADB.pushDir with zip support fails with:
zip/unzip failure: falling back to normal push
Traceback (most recent call last):
File "/home/jgriffin/mozbase/mozdevice/mozdevice/devicemanagerADB.py", line 221, in pushDir
retryLimit=retryLimit).stdout.read()
TypeError: _runCmdAs() got an unexpected keyword argument 'retryLimit'
This is because the patch in bug 816216 added a 'retryLimit' parameter to the _runCmdAs call inside pushDir, but failed to add retryLimit to the _runCmdAs function definition.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → mihneadb
|
|
Assignee | |
Comment 1•12 years ago
|
||
Whoops, actually that line was not supposed to use retryLimit since only checkCmd uses retryLimit and runCmd* does not.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #693600 -
Flags: review?(jgriffin)
|
Reporter | |
Comment 3•12 years ago
|
||
Comment on attachment 693600 [details] [diff] [review]
fix the call to runCmdAs
Review of attachment 693600 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for the quick fix.
Attachment #693600 -
Flags: review?(jgriffin) → review+
|
|
Reporter | |
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•