82274 - XPCJSRuntime leaks mDyingWrappedNativeProtoMap

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

According to the Boehm GC, the XPCJSRuntime leaks its
mDyingWrappedNativeProtoMap (because it's not |delete|-ed in the destructor, I
presume).

Comment 1

[David Bradley]

John, I assume it just needs the delete added like the rest of the maps? I'll 
attach a patch for the additional code. Let me know if there is something 
conceptually wrong with delete this here. I seem to remember some discussions 
surround the dying prototypes map before, but don't remember the specifics.

Comment 2

[David Bradley]

Attachment: Adds delete of mDyingWrappedNativeProtoMap to destructor

Comment 3

[John Bandhauer]

r/sr=jband

Two nits...

- Please make patches from the closest directory to the files which will compose 
the patch. In this case mozilla/js/src/xpconnect/src. If you needed to make a 
patch of files in xpconnect/idl and xpconnect/src together then you'd build the 
patch from mozilla/js/src/xpconnect. This makes it easier for all.

- Like it or not you are inheriting code with a particular style. Our most 
overriding sytle rule is to maintain the consistency of the style in place in 
any particular file. Specifically here, no space between 'if' and '('. Please 
fix that in your change.

Comment 4

[David Bradley]

Attachment: Patch without space after if and made at the closest dir

Comment 5

[David Bradley]

Attachment: ! Missed an if

Comment 6

[John Bandhauer]

dbradley's patches checked in as part of fix for bug 84020

Comment 7

[Phil Schwartau]

Marking Verified -