822754 - B2G AutoMounter doesn't deal with out-of-order events

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dave Hylands [:dhylands]]

In particular, the AutoMounter currently assumes that disk removal/insertion events will be followed by state change events.

It appears that they can occur in the order: state change, disk-insertion (see bug 822465)

Comment 1

[Dave Hylands [:dhylands]]

Attachment: Deal with disk insertion event after state change event

This should address the problem seen in bug 822465. Since I can't reproduce, could I get you to try it?

Comment 2

[Dave Hylands [:dhylands]]

Updated flags to match bug 822465

Comment 3

[Dave Hylands [:dhylands]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1b92a38beffd

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1b92a38beffd

Comment 5

[Diego Wilson [:diego]]

FYI This seems to work only if I do get root access through |adb root|

Comment 6

[Dave Hylands [:dhylands]]

Sorry, I don't understand. What seems to work?

Or are you saying that the original bug 822465 only manifests when the adb shell is non-root?

Comment 7

[Diego Wilson [:diego]]

(In reply to Dave Hylands [:dhylands] from comment #6)
> Sorry, I don't understand. What seems to work?
> 
> Or are you saying that the original bug 822465 only manifests when the adb
> shell is non-root?

Yes, I had to do an |adb root| on my -userdebug build for the SD card to mount. Although now I'm not sure my build picked up the attached patch. I'll try again tomorrow

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/4508594f9323