Closed Bug 822754 Opened 10 years ago Closed 10 years ago

B2G AutoMounter doesn't deal with out-of-order events

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-basecamp:-, firefox20 fixed, b2g18+ fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 wontfix)

Status:
RESOLVED FIXED
Milestone:
B2G C4 (2jan on)
Project Flags:
blocking-basecamp -
Tracking Flags:
Tracking Status
firefox20 --- fixed
b2g18 + fixed
b2g18-v1.0.0 --- wontfix
b2g18-v1.0.1 --- wontfix

People

(Reporter: dhylands, Assigned: dhylands)

Details

Attachments

(1 file)

Deal with disk insertion event after state change event
1.30 KB, patch
philikon
: review+
Details | Diff | Splinter Review 
In particular, the AutoMounter currently assumes that disk removal/insertion events will be followed by state change events.

It appears that they can occur in the order: state change, disk-insertion (see bug 822465)
This should address the problem seen in bug 822465. Since I can't reproduce, could I get you to try it?
Flags: needinfo?(dwilson)
Updated flags to match bug 822465
blocking-basecamp: --- → -
tracking-b2g18: --- → +
Assignee: nobody → dhylands
Attachment #693552 - Flags: review?(kyle)
Attachment #693552 - Flags: review?(kyle) → review+
https://hg.mozilla.org/mozilla-central/rev/1b92a38beffd
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
FYI This seems to work only if I do get root access through |adb root|
Flags: needinfo?(dwilson)
Sorry, I don't understand. What seems to work?

Or are you saying that the original bug 822465 only manifests when the adb shell is non-root?
(In reply to Dave Hylands [:dhylands] from comment #6)
> Sorry, I don't understand. What seems to work?
> 
> Or are you saying that the original bug 822465 only manifests when the adb
> shell is non-root?

Yes, I had to do an |adb root| on my -userdebug build for the SD card to mount. Although now I'm not sure my build picked up the attached patch. I'll try again tomorrow
You need to log in before you can comment on or make changes to this bug.