If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

"ASSERTION: can't call on root" (ReplaceAnimationRule calling nsRuleNode::GetLevel)

RESOLVED FIXED in mozilla20

Status

()

Core
CSS Parsing and Computation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: bz)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla20
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 693540 [details]
testcase

###!!! ASSERTION: can't call on root: '!IsRoot()', file layout/style/nsRuleNode.h, line 650
(Reporter)

Comment 1

5 years ago
Created attachment 693542 [details]
stack
Hmm.  Seems like this would get hit if aOldAnimRule is the least-specific rule involved, right?
Blocks: 653645
Though it's not quite clear to me how you can end up with an animation rule that's least-specific if the animation comes from author rules...
In this case, when ReplaceAnimationRule is called aOldRuleNode is a rulenode for an animation rule and its parent is the root, and aNewAnimationRule is null, so it all makes sense.
Assignee: nobody → bzbarsky
Whiteboard: [need review]
Created attachment 694527 [details] [diff] [review]
Be a bit more careful with our level assert in ReplaceAnimationRule.
Attachment #694527 - Flags: review?(dbaron)
Blocks: 823124
No longer blocks: 823124
Comment on attachment 694527 [details] [diff] [review]
Be a bit more careful with our level assert in ReplaceAnimationRule.

r=dbaron

I presume you tested the crashtest aborted without the patch?
Attachment #694527 - Flags: review?(dbaron) → review+
It doesn't abort, but it does assert without the patch, so fails tests.
https://hg.mozilla.org/integration/mozilla-inbound/rev/079d46ec65d2
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla20
https://hg.mozilla.org/mozilla-central/rev/079d46ec65d2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.