Closed Bug 822771 Opened 9 years ago Closed 9 years ago

HSTS preload list script needs to set timeouts for its XHRs

Categories

(Core :: Security: PSM, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: keeler, Assigned: keeler)

References

Details

Attachments

(1 file)

security/manager/tools/getHSTSPreloadList.js makes a request to each site on Chrome's HSTS preload list. At least one of these sites takes about forever to respond, which means the script hangs and we get no useful output. Adding a timeout to the requests it makes is a reasonable solution. The one thing we have to be careful about is removing sites from the list due to transient outages, but that's always been the case, so this really changes nothing.
Attached patch patchSplinter Review
Brian - I don't know how busy you are, but I imagine this will take all of 15 seconds to review (unless this has some consequences I'm not aware of).
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #693555 - Flags: review?(bsmith)
Attachment #693555 - Flags: review?(bsmith) → review+
https://hg.mozilla.org/mozilla-central/rev/5c248ef0fe62
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.