822816 - [AccessFu] Double tapping does not activate things in JellyBean

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

https://groups.google.com/d/msg/eyes-free/Ghcu3HGEdRE/oQlB9XhfQpMJ

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Fix double tap activation in jellybean.

Remove unneeded mouse event listeners, and don't user 'hover' identifier when actual identifier is 0.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 693606 [details] [diff] [review]
Fix double tap activation in jellybean.

Review of attachment 693606 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

::: accessible/src/jsat/TouchAdapter.jsm
@@ +122,5 @@
>          for (var i = 0; i < changedTouches.length; i++) {
>            let touch = changedTouches[i];
>            let touchPoint = new TouchPoint(touch, timeStamp, this._dpi);
> +          let identifier = (touch.identifier == undefined) ?
> +            this.HOVER_ID : touch.identifier;

Oh, right because touch.identifier can be valid but falsey (facepalm).

Comment 3

[Eitan Isaacson [:eeejay]]

(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 693606 [details] [diff] [review]
> Fix double tap activation in jellybean.
> 
> Review of attachment 693606 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me
> 
> ::: accessible/src/jsat/TouchAdapter.jsm
> @@ +122,5 @@
> >          for (var i = 0; i < changedTouches.length; i++) {
> >            let touch = changedTouches[i];
> >            let touchPoint = new TouchPoint(touch, timeStamp, this._dpi);
> > +          let identifier = (touch.identifier == undefined) ?
> > +            this.HOVER_ID : touch.identifier;
> 
> Oh, right because touch.identifier can be valid but falsey (facepalm).

Yes, falseyness is tricky in js.

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/73ce12dc950b

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/73ce12dc950b