Created attachment 693692 [details] [diff] [review] Fix Add a missing null-check
Created attachment 693701 [details] Bug fix. Adds a missing null-check. (+ Better patch file with 8 lines of context.)
Created attachment 693702 [details] [diff] [review] Bug fix. Clicking the patch checkbox this time.
You can avoid uploading a new patch and update the "patch-ness" of the existing attachment in the attachment details page if you click the "(edit details)" link.
Comment on attachment 693702 [details] [diff] [review] Bug fix. In COMPUTE_START_RESET, if we find that presContext is null we construct a new (default) style struct for the parent's style to use those values. I think if we take the else branch here if parent is null then we will compute the value to whatever column-rule-color is when mColumnRuleColorIsForeground is true. I am not sure that mColumnRuleColor is valid in that case. In nsStyleColumn's construct it's set to NS_RGB(0, 0, 0), but I don't know if it remains that colour. In any case, this will be different from nsStyleColor's default mColor value, which is set to aPresContext->DefaultColor() in nsStyleColor's constructor. I feel like we ought to be using that. You can just create a local nsStyleColor to get this mColor out of.
Created attachment 698091 [details] [diff] [review] Updated patch per review comments.
Comment on attachment 698091 [details] [diff] [review] Updated patch per review comments. Looks good.
Attachment #698091 - Flags: review?(cam) → review+
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.