823004 - B2G STK: STK Set-Up idle mode doesn't work properly

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect, P2)

Description

[mbarone]

Gecko: cb6ee76
Gaia: 16006ea

Precondition: To perform this test you need the SIM toolkit Kit with the SIM number 10

STR
1. Introduce the SIM number 10
2. In settings go to SIM Toolkit option
3. Wait some seconds

EXPECTED RESULT
The SIM must send the event Profile Download

ACTUAL RESULT
Nothing happens

Comment 1

[Daniel Coloma:dcoloma]

dpv, can you check it is a certification blocker and if so link to the corresponding bug? If it is a blocker, can we check for extra-information about when this command is used?

Comment 2

[David Palomino [:dpalomino]]

Hi, 

Just fyi, with the Set Up Idle Mode Text proactive command the SIM sends a text which will be displayed by the terminal when being in idle mode. 

This is a quite basic STK feature, and it'd be blocker for v1. Adding also dependency... 

Cheers, 
David

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Hi,

Is something new in settings which avoids the execution of NotificationHelper?

When I execute this code from icc.js:

  function displayNotification(command) {
    var options = command.options;
    NotificationHelper.send('STK', options.text);
  }

I receive this platform error:

E/GeckoConsole(  108): [JavaScript Error: "invalid 'in' operand message" {file: "chrome://browser/content/shell.js" line: 658}]

The same code in dialer or SMS is working well.

Comment 4

[Fabien Cazenave [:kaze]]

Not that I know of, but I never used the NotificationHelper so far so I’m probably not the right person to ask.

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Fixed STK notifications. Moved STK notifications to system's ICC JS

NotificationHelper doesn't work on settings app (?). So I moved notifications to the system app (icc_cache.js).

Anyway, I think this is a better approach since we avoid to open settings app only to set a notification into the notification bar when the ICC requires it.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 694743 [details] [diff] [review]
Fixed STK notifications. Moved STK notifications to system's ICC JS

Let's fix the real bug in b2g/chrome/content/shell.js instead of moving more code in the System app.

Comment 7

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch shell.js

Small fix for shell.js.

Comment 8

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8dd9b338324c

Comment 9

[Graeme McCutcheon [:graememcc]]

https://hg.mozilla.org/mozilla-central/rev/8dd9b338324c

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b2d7c39b98d3
https://hg.mozilla.org/releases/mozilla-b2g18/rev/7def9849a8a1