Closed
Bug 823085
Opened 12 years ago
Closed 7 years ago
Flash enables itself after some time, even though its disabled.
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: hpr, Unassigned)
References
Details
Attachments
(1 file)
69.59 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20100101 Firefox/17.0 Build ID: 20121128204232 Steps to reproduce: I disabled flash, because... flash is insecure and unnecessary + bloated. Actual results: Flash stays disabled for some time, but suddenly, without restarting FF, flash get's enabled again, although this seems somewhat buggy reflected in the UI, see screenshot: http://www.pixo.no/pub/img/prt/bZO.png From that view you are unable to disable it and you need to restart FF to disable it again. Expected results: Never ever ever ever ever enable itself, without me doing it.
Comment 1•12 years ago
|
||
Did you get an update of flash in the background ?
Component: Untriaged → Plug-ins
Product: Firefox → Core
As of writing I have the newest one installed, version 11.5.502.135, on my local system it has the created/modified date of 12.12.12 (!), Although I cannot be a 100% sure, I think this has happened even without a update in the background. (On the other hand, it kind of makes sense after Adobe started to do automatic upgrades of flash in the background).
Comment 3•12 years ago
|
||
Umm, on my Windows Boxes across all Firefox Installations my Shockwave Flash Entry (admittedly its Betas) in the Addon Manager's Plugins Pane has a Version Number - in your Screenshot it does not. Just wondering if it's legit ....
Comment 4•12 years ago
|
||
and there is a "options" and a "remove" button and they should not be there
It is very legit, hence why I wrote "somewhat buggy reflected in the UI", because of the extra buttons, wrong placement and color. After restarting Firefox, disabling the Flash-plugin, it looks like this, normal: http://www.pixo.no/pub/img/prt/lUW.png (Pressing any of the buttons have no effect, I must restart Firefox to disable it again). I have the exact same problem at my home computer as well.
Comment 6•11 years ago
|
||
(In reply to Håkon from comment #0) > suddenly, without restarting FF, > flash get's enabled again, although this seems somewhat buggy reflected in > the UI Can you figure out what did you do exactly? What pages did you visit? You could also try checkin the "never check for updates" option when installing Flash. PS: I see you have a lot of plugins disabled. There is a new Firefox feature called Click to Play, which initially blocks all your plugins, makes them to click to play (plugins will require an extra click to activate and start “playing” content). You can try this by going to about:config and set the "plugins.click_to_play" pref on TRUE.
Comment 7•11 years ago
|
||
Clicking the "options" button actually navigates me to a blank page of some sort, I think. Also note: Flash is not actually disabled, even though the UI says it is. Loading the plugins page of the addons manager shows the following in the error console: Timestamp: 1/11/2013 12:32:59 PM Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.lastModifiedTime] Source File: resource://gre/modules/PluginProvider.jsm Line: 281
Comment 8•11 years ago
|
||
I'm not sure what part of this is a bug in the addons UI and what part is a bug in the plugins backend.
Comment 9•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #7) > Created attachment 701169 [details] > Flash plugin with options/enable/disable entries > > Clicking the "options" button actually navigates me to a blank page of some > sort, I think. > > Also note: Flash is not actually disabled, even though the UI says it is. > > Loading the plugins page of the addons manager shows the following in the > error console: Timestamp: 1/11/2013 12:32:59 PM > Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 > (NS_ERROR_FILE_NOT_FOUND) [nsIFile.lastModifiedTime] > Source File: resource://gre/modules/PluginProvider.jsm > Line: 281 Root problem is likely in nsPluginHost. It's giving the add-ons manager an nsIPluginTag for flash with a filename that doesn't exist. That's causing the UI to fail very early in updating so you basically can't trust anything you see there, not even whether it is greyed out or not. It would be easy to fix the UI to deal with a missing file, but if pluginhost is giving is an incorrect filename I'm not sure whether any of the other info it gives us is correct.
Comment 10•11 years ago
|
||
Well... since I have this in-browser, I just wrote a little script to get the data from nsIPluginHost.getPluginTags and got this result: [{ "filename": "NPSWF32_11_6_602_137.dll", "name": "Shockwave Flash", "version": "11.6.602.137", "fullpath": "C:\\Windows\\SysWOW64\\Macromed\\Flash\\NPSWF32_11_6_602_137.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npjp2.dll", "name": "Java(TM) Platform SE 6 U37", "version": "6.0.370.6", "fullpath": "C:\\Program Files (x86)\\Java\\jre6\\bin\\plugin2\\npjp2.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npdeployJava1.dll", "name": "Java Deployment Toolkit 6.0.370.6", "version": "6.0.370.6", "fullpath": "C:\\Windows\\SysWOW64\\npdeployJava1.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npnv3dv.dll", "name": "NVIDIA 3D Vision", "version": "7.17.13.697", "fullpath": "C:\\Program Files (x86)\\NVIDIA Corporation\\3D Vision\\npnv3dv.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npnv3dvstreaming.dll", "name": "NVIDIA 3D VISION", "version": "7.17.13.697", "fullpath": "C:\\Program Files (x86)\\NVIDIA Corporation\\3D Vision\\npnv3dvstreaming.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npGoogleUpdate3.dll", "name": "Google Update", "version": "1.3.21.123", "fullpath": "C:\\Users\\bsmedberg\\AppData\\Local\\Google\\Update\\1.3.21.123\\npGoogleUpdate3.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npGoogleUpdate3.dll", "name": "Google Update", "version": "1.3.21.123", "fullpath": "C:\\Program Files (x86)\\Google\\Update\\1.3.21.123\\npGoogleUpdate3.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npbsmedberg-testplugin.dll", "name": "someproduct", "version": "1.0.0.19", "fullpath": "C:\\Users\\bsmedberg\\Documents\\Visual Studio 2010\\Projects\\bsmedberg-testplugin\\Debug\\npbsmedberg-testplugin.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npctrl.dll", "name": "Silverlight Plug-In", "version": "4.1.10329.0", "fullpath": "c:\\Program Files (x86)\\Microsoft Silverlight\\4.1.10329.0\\npctrl.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npgeplugin.dll", "name": "Google Earth Plugin", "version": "6.1.0.5001", "fullpath": "C:\\Program Files (x86)\\Google\\Google Earth\\plugin\\npgeplugin.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin7.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin7.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin7.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin7.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin6.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin6.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin6.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin6.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin5.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin5.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin5.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin5.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin4.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin4.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin4.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin4.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin3.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin3.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin3.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin3.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin2.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin2.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin2.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin2.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\QuickTime\\Plugins\\npqtplugin.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqtplugin.dll", "name": "QuickTime Plug-in 7.6.9", "version": "7.6.9.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npqtplugin.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "nppdf32.dll", "name": "Adobe Acrobat", "version": "10.0.1.434", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\nppdf32.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "nptest.dll", "name": "Test Plug-in", "version": "1.0.0.0", "fullpath": "C:\\Users\\bsmedberg\\AppData\\Roaming\\Mozilla\\Firefox\\Profiles\\b1eqskvb.default\\plugins\\nptest.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npqmp071706000001.dll", "name": "Move Streaming Media Player", "version": "717.6.0.1", "fullpath": "C:\\Users\\bsmedberg\\AppData\\Roaming\\Move Networks\\plugins\\npqmp071706000001.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npquakezero.dll", "name": "QUAKE LIVE", "version": "0.1.0.277", "fullpath": "C:\\ProgramData\\id Software\\QuakeLive\\npquakezero.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "NPSibelius.dll", "name": "ScorchPlugin", "version": "6.1.5.22", "fullpath": "C:\\Program Files (x86)\\Sibelius Software\\Scorch\\Netscape\\NPSibelius.dll", "disabled": true, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }, { "filename": "npDivxPlayerPlugin.dll", "name": "DivX Player Netscape Plugin", "version": "6.1.0.0", "fullpath": "C:\\Program Files (x86)\\Minefield\\plugins\\npDivxPlayerPlugin.dll", "disabled": false, "blocklisted": false, "clicktoplay": false, "mimetypes": [] }] I have checked, and each of these files does exist. Is it possible that the addon manager is caching an old copy of the plugin tags? Note that when Flash auto-updates, we load a new tag for it, and then when the last instance of the old version goes away we unload the old version and (I think) throw away that tag. Flash then eventually deletes the file.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 11•11 years ago
|
||
But note! By going through AddonManager.jsm, the Addon with name "Shockwave Flash" says .pluginLibraries = NPSWF32_11_6_602_108.dll, which is last week's version.
Comment 12•11 years ago
|
||
Oh right, I forgot we never fixed bug 554780. That'll cover the UI issues then. The fact it re-enabled itself is probably pluginhost not carrying state across to the new plugin it detects
Depends on: 554780
Comment 13•11 years ago
|
||
(In reply to Dave Townsend (:Mossop) from comment #12) > The fact it re-enabled itself is probably pluginhost not carrying > state across to the new plugin it detects Right, i filed bug 830267 on what probably happens here.
Comment 14•11 years ago
|
||
Mossop, if bug 554780 is not easy, can we implement the workaround exception handler so that at least the UI isn't as broken?
Flags: needinfo?(dtownsend+bugmail)
Comment 15•11 years ago
|
||
11.6.602.146 was released yesterday so it's possible there is a fix in there.
Comment 16•11 years ago
|
||
(In reply to Benjamin Smedberg [:bsmedberg] from comment #14) > Mossop, if bug 554780 is not easy, can we implement the workaround exception > handler so that at least the UI isn't as broken? Even if we just catch the exception we'll still just be displaying the state of the old nsIPluginTag and interacting with it won't have any effect on the real flash. We can probably do a good-enough implementation of bug 554780. The plugin host already sends out an observer notification on plugin changes IIRC, we just need to update the cache the add-ons manager keeps on that. Has something in particular changed that makes this more of a problem now? As far as I know this code has been this way since Firefox 4.
Flags: needinfo?(dtownsend+bugmail)
Comment 17•11 years ago
|
||
(In reply to Dave Townsend (:Mossop) from comment #16) > Has something in particular changed that makes this more of a problem now? > As far as I know this code has been this way since Firefox 4. bug 686335 and the in the replacement of the plugin while in use could have changed something
Comment 18•11 years ago
|
||
Yes, and Flash now updates in the background with a new filename (e.g. NPSWF32_11_5_500_16.dll) so it gets a new plugintag.
Comment 19•11 years ago
|
||
Did bug 554780 fix this or are there still issues?
Comment 20•11 years ago
|
||
STR: 1. Remove Flash from your computer 2. Install an older Flash (I used 11.2.202.235) http://helpx.adobe.com/flash-player/kb/archived-flash-player-versions.html 3. Start Firefox and leave it open 4. Install latest Flash http://get.adobe.com/flashplayer/ Actual result: Broken Addons Manager UI - screenshot in comment 7 And it's not fixed by bug 554780. Tested on nightly 2013-03-05, FF 20b3
Comment 21•7 years ago
|
||
Resolving old bugs which are likely not relevant any more, since NPAPI plugins are deprecated.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•